ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Mohammed Shafi Shajakhan (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	Michael Scott <michael.scott@linaro.org>
Subject: Re: odd msg using kvalo firmware-5.bin w/ KillerAC 1535(QCA6174)
Date: Thu, 20 Apr 2017 06:34:00 +0000	[thread overview]
Message-ID: <87a87b7fl4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1492660230116.11983@qti.qualcomm.com> (Mohammed Shafi Shajakhan's message of "Thu, 20 Apr 2017 03:50:30 +0000")

(please don't top post)

"Mohammed Shafi Shajakhan (Mohammed Shafi)" <mohammed@qti.qualcomm.com>
writes:

> my quick analysis suggests this belongs to
> 'WMI_TLV_GRP_STATS' 
>
> WMI_TLV_STATS_EXT_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_STATS), equals to 90112 (0x16000)
>         WMI_TLV_IFACE_LINK_STATS_EVENTID, 90113
>         WMI_TLV_PEER_LINK_STATS_EVENTID, 90114
>         WMI_TLV_RADIO_LINK_STATS_EVENTID, 90015
>              .... ?
>         WMI_TLV_NLO_MATCH_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_NLO_OFL),


I checked and I think this is a some kind of RSSI stats event. I assume
that's a new feature coming from RM.4.4 branch. (Michael said on IRC he
is not seeing that with RM.2.0 branch.)

> but this should be a harmless warning message indicating the host had not implemented
> any action for this particular event.
>
> For example in 10.2 wmi.c
>
>
>    case WMI_10_2_GPIO_INPUT_EVENTID:
>         case WMI_10_2_PEER_RATECODE_LIST_EVENTID:
>         case WMI_10_2_GENERIC_BUFFER_EVENTID:
>         case WMI_10_2_MCAST_BUF_RELEASE_EVENTID:
>         case WMI_10_2_MCAST_LIST_AGEOUT_EVENTID:
>         case WMI_10_2_WDS_PEER_EVENTID:
>                 ath10k_dbg(ar, ATH10K_DBG_WMI,
>                            "received event id %d not implemented\n", id);
>                 break;

Yes, it's harmless but ath10k should not print that warning to not
distract the users. Can someone make a patch to silent the warning that
similarly like with WMI_10_2_WDS_PEER_EVENTID above?

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2017-04-20  6:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 18:37 odd msg using kvalo firmware-5.bin w/ KillerAC 1535(QCA6174) Michael Scott
2017-04-20  3:50 ` Mohammed Shafi Shajakhan (Mohammed Shafi)
2017-04-20  4:01   ` Adrian Chadd
2017-04-20  6:34   ` Kalle Valo [this message]
2017-04-21 19:00     ` Ryan Hsu
2017-04-21 19:53       ` Adrian Chadd
2017-04-24  6:44         ` Marcin Rokicki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a87b7fl4.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=michael.scott@linaro.org \
    --cc=mohammed@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox