From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZIY1T-0007li-Um for ath10k@lists.infradead.org; Fri, 24 Jul 2015 08:08:04 +0000 From: Kalle Valo Subject: Re: [PATCH 1/2] ath10k: Fix memory alloc failure in qca99x0 during wmi svc rdy event References: <1437456178-7862-1-git-send-email-rmani@qti.qualcomm.com> Date: Fri, 24 Jul 2015 11:07:37 +0300 In-Reply-To: <1437456178-7862-1-git-send-email-rmani@qti.qualcomm.com> (Raja Mani's message of "Tue, 21 Jul 2015 10:52:57 +0530") Message-ID: <87a8umf06u.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Raja Mani Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Raja Mani writes: > Host memory required for firmware is allocated while handling > wmi service ready event. Right now, wmi service ready is handled > in tasklet context and it calls dma_alloc_coherent() with atomic > flag (GFP_ATOMIC) to allocate memory in host needed for firmware. > The problem is, dma_alloc_coherent() with GFP_ATOMIC fails in > the platform (at least in AP platform) where it has less atomic > pool memory (< 2mb). QCA99X0 requires around 2 MB of host memory > for one card, having additional QCA99X0 card in the same platform > will require similarly amount of memory. So, it's not guaranteed that > all the platform will have enough atomic memory pool. > > Fix this issue, by handling wmi service ready event in workqueue > context and calling dma_alloc_coherent() with GFP_KERNEL. mac80211 work > queue will not be ready at the time of handling wmi service ready. > So, it can't be used to handle wmi service ready. Also, register work > gets scheduled during insmod in existing ath10k_wq and waits for > wmi service ready to completed. Both workqueue can't be used for > this purpose. New auxiliary workqueue is added to handle wmi service > ready. > > Signed-off-by: Raja Mani I haven't reviewed this yet, but noticed a new warning: drivers/net/wireless/ath/ath10k/wmi.c:3881:6: warning: symbol 'ath10k_wmi_event_service_ready_work' was not declared. Should it be static? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k