From: Kalle Valo <kvalo@codeaurora.org>
To: pillair@codeaurora.org
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: dma unmap mgmt tx buffer if wmi cmd send fails
Date: Wed, 28 Feb 2018 15:07:09 +0200 [thread overview]
Message-ID: <87bmg9s1oi.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1518169330-4934-1-git-send-email-pillair@codeaurora.org> (pillair@codeaurora.org's message of "Fri, 9 Feb 2018 15:12:10 +0530")
pillair@codeaurora.org writes:
> From: Rakesh Pillai <pillair@codeaurora.org>
>
> WCN3990 sends mgmt frames by reference via WMI.
> The host dma maps the mgmt frame and sends the physical
> address to the firmware in the wmi command. Since the
> dma mapping is done in the gen_mgmt_tx and if the wmi
> command send fails, the corresponding mgmt frame is
> not being dma unmapped.
>
> Fix the missing dma unmapping of mgmt tx frame when
> wmi command sending fails for mgmt tx by reference
> via WMI. The already exisiting mgmt tx using copy by
> value does not need such dma unmapping.
> Add a separate wmi-tlv op for mgmt tx via ref, which
> takes care of unmapping the dma address, in case of
> wmi command sending failure.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
ath10k-check found two warnings, I fixed those in pending branch:
drivers/net/wireless/ath/ath10k/wmi-ops.h:130: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/wmi-ops.h:380: Alignment should match open parenthesis
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-02-28 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 9:42 [PATCH] ath10k: dma unmap mgmt tx buffer if wmi cmd send fails pillair
2018-02-28 13:07 ` Kalle Valo [this message]
2018-03-14 9:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmg9s1oi.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox