ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Anilkumar Kolli <akolli@qti.qualcomm.com>,
	"akolli@codeaurora.org" <akolli@codeaurora.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4
Date: Thu, 30 Nov 2017 16:38:54 +0000	[thread overview]
Message-ID: <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <DAB5EBB8-C820-4056-8AAB-063D05F38BD5@toke.dk> ("Toke \=\?utf-8\?Q\?H\=C3\=B8iland-J\=C3\=B8rgensen\=22's\?\= message of "Thu, 30 Nov 2017 17:28:42 +0100")

Toke Høiland-Jørgensen <toke@toke.dk> writes:

>>> +struct ath10k_10_2_peer_tx_stats {
>>> +	u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	__le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	__le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	__le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	u8 flags[PEER_STATS_FOR_NO_OF_PPDUS];
>>> +	__le32 tx_duration;
>>> +	u8 tx_ppdu_cnt;
>>> +	u8 peer_id;
>>> +} __packed;
>>
>>Toke, hopefully the tx_duration value here helps with ATF
>>implementation
>>using QCA988X.
>
> Awesome! What's the semantics of this field? Just total 
> duration spent serving that station in the reporting interval?
> Does it include retry attempts?

I have no clue :) I just noticed this while I was reviewing the patch
internally and immediately recalled our discussions at Seoul. I can try
to find out, but that will take a long time as I have way too much stuff
pending at the moment. Hopefully someone more knowledgeable (Anilkumar?)
can chime in and help.

-- 
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2017-11-30 16:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 12:58 [PATCH 0/2] ath10k: tx stats for 10.2.4 akolli
2017-11-30 12:58 ` [PATCH 1/2] ath10k: move pktlog_filter out of ath10k_debug akolli
2017-11-30 12:58 ` [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 akolli
2017-11-30 16:14   ` Kalle Valo
2017-11-30 16:28     ` Toke Høiland-Jørgensen
2017-11-30 16:38       ` Kalle Valo [this message]
2017-12-01  4:23         ` akolli
2017-12-01 13:41           ` Toke Høiland-Jørgensen
2017-12-01 14:49             ` Kalle Valo
2017-12-01 15:29               ` Toke Høiland-Jørgensen
2017-12-01 15:45                 ` Johannes Berg
2017-12-01 15:54                   ` Toke Høiland-Jørgensen
2017-12-01 15:58                     ` Johannes Berg
2017-12-02  9:53                       ` Toke Høiland-Jørgensen
2017-12-01 10:45   ` Maxime Bizon
2017-12-01 13:48     ` akolli
2017-12-01 15:05       ` Maxime Bizon
2017-12-01 15:53         ` Christian Lamparter
2017-12-01 16:09           ` Maxime Bizon
2017-12-04 13:24         ` akolli
2017-12-04 14:23           ` Maxime Bizon
2017-12-05  5:26             ` akolli
2017-12-01 15:44       ` Kalle Valo
2017-12-04 11:20         ` akolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmjjzppd.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=akolli@codeaurora.org \
    --cc=akolli@qti.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox