From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: remove htt rx amsdu clear retry bit hack
Date: Wed, 13 Nov 2013 15:23:18 +0200 [thread overview]
Message-ID: <87bo1o77w9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQkLsbwEAX6RomC_ZA-rtL6q1Q871=9n-Mgry=AZgrKs6Q@mail.gmail.com> (Michal Kazior's message of "Wed, 13 Nov 2013 12:38:04 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
>> - /* FIXME: Hopefully this is a temporary measure.
>> - *
>> - * Reporting individual A-MSDU subframes means each reported frame
>> - * shares the same sequence number.
>> - *
>> - * mac80211 drops frames it recognizes as duplicates, i.e.
>> - * retransmission flag is set and sequence number matches sequence
>> - * number from a previous frame (as per IEEE 802.11-2012: 9.3.2.10
>> - * "Duplicate detection and recovery")
>> - *
>> - * To avoid frames being dropped clear retransmission flag for all
>> - * received A-MSDUs.
>> - *
>> - * Worst case: actual duplicate frames will be reported but this should
>> - * still be handled gracefully by other OSI/ISO layers. */
>> - hdr->frame_control &= cpu_to_le16(~IEEE80211_FCTL_RETRY);
>> -
>> first = skb;
>> while (skb) {
>> void *decap_hdr;
>>
>
> You're missing RX_FLAG_AMSDU_MORE. All subframes (except the last one)
> from an A-MSDU that are reported separately must have the bit set in
> status->flag. Only then mac80211 can apply retransmission/duplication
> check properly.
I'll send v2, thanks for the review.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2013-11-13 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 11:28 [PATCH] ath10k: remove htt rx amsdu clear retry bit hack Kalle Valo
2013-11-13 11:38 ` Michal Kazior
2013-11-13 13:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo1o77w9.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox