Re: [PATCH v6 2/4] mac80211: Import airtime calculation code from mt76

Johannes Berg
2019-11-08T10:58:01Z

On Fri, 2019-11-08 at 11:55 +0100, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > On Wed, 2019-10-23 at 11:59 +0200, Toke Høiland-Jørgensen wrote:
> > > From: Toke Høiland-Jørgensen <toke@redhat.com>
> > >
> > > Felix recently added code to calculate airtime of packets to the mt76
> > > driver. Import this into mac80211 so we can use it for airtime queue limit
> > > calculations later.
> > >
> > > The airtime.c file is copied verbatim from the mt76 driver, and adjusted to
> > > use mac80211 data structures instead (which is fairly straight forward).
> > > The per-rate TX rate calculation is split out to its own
> > > function (ieee80211_calc_tx_airtime_rate()) so it can be used directly for
> > > the AQL calculations added in a subsequent patch.
> >
> > Any way it could be exposed by mac80211 back to the drivers, perhaps, to
> > share it?
>
> Didn't I already export some of the functions? My intention was to do
> that, certainly, and to patch mt76 to switch to using them once the
> trees have converged...

Yeah, I think you did. Sounds good.

johannes