Re: [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL)

Toke Høiland-Jørgensen
2019-11-08T10:56:42Z

Johannes Berg <johannes@sipsolutions.net> writes:

> On Wed, 2019-10-23 at 11:59 +0200, Toke Høiland-Jørgensen wrote:
>>
>>
>> +void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local,
>> + struct sta_info *sta, u8 ac,
>> + u16 tx_airtime, bool tx_completed)
>> +{
>> + spin_lock_bh(&local->active_txq_lock[ac]);
>> + if (tx_completed) {
>> + if (sta) {
>> + if (WARN_ONCE(sta->airtime[ac].aql_tx_pending < tx_airtime,
>> + "TXQ pending airtime underflow: %u, %u",
>> + sta->airtime[ac].aql_tx_pending, tx_airtime))
>
> Maybe add the STA/AC to the message?

Can do. Any idea why we might be seeing underflows (as Kan reported)?

-Toke