From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from alexa-out.qualcomm.com ([129.46.98.28]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1e2z5X-0007FF-Ge for ath10k@lists.infradead.org; Fri, 13 Oct 2017 12:29:17 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: spectral: Simplify error checking Date: Fri, 13 Oct 2017 12:28:50 +0000 Message-ID: <87fuannse6.fsf@kamboji.qca.qualcomm.com> References: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> In-Reply-To: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> (Christos Gkekas's message of "Sun, 8 Oct 2017 20:30:26 +0100") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Christos Gkekas Cc: "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" Christos Gkekas writes: > Variable val is unsigned so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > --- > drivers/net/wireless/ath/ath10k/spectral.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c > index dd9cc09..1867937 100644 > --- a/drivers/net/wireless/ath/ath10k/spectral.c > +++ b/drivers/net/wireless/ath/ath10k/spectral.c > @@ -403,10 +403,7 @@ static ssize_t write_file_spectral_count(struct file *file, > return -EFAULT; > > buf[len] = '\0'; > - if (kstrtoul(buf, 0, &val)) > - return -EINVAL; > - > - if (val < 0 || val > 255) > + if (kstrtoul(buf, 0, &val) || val > 255) > return -EINVAL; Removing the check for negative is correct but I don't think you are simplifying anything, on the contrary it's harder to read. Please keep the two if statements separate. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k