ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Raja Mani <rmani@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fix compilation warnings in wmi phyerr pull function
Date: Wed, 26 Aug 2015 12:34:26 +0300	[thread overview]
Message-ID: <87fv361jh9.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1440162756-4025-1-git-send-email-rmani@qti.qualcomm.com> (Raja Mani's message of "Fri, 21 Aug 2015 18:42:36 +0530")

Raja Mani <rmani@qti.qualcomm.com> writes:

> Below compilation warnings are observed in gcc version 4.8.2.
> Even though it's not seen in bit older gcc versions (for ex, 4.7.3),
> It's good to fix it by changing format specifier from %d to
> %zd in wmi pull phyerr functions.
>
> wmi.c: In function 'ath10k_wmi_op_pull_phyerr_ev':
> wmi.c:3567:8: warning: format '%d' expects argument of type 'int',
>               but argument 4 has type 'long unsigned int' [-Wformat=]
>               left_len, sizeof(*phyerr));
>                         ^
> wmi.c: In function 'ath10k_wmi_10_4_op_pull_phyerr_ev':
> wmi.c:3612:8: warning: format '%d' expects argument of type 'int',
> 	      but argument 4 has type 'long unsigned int' [-Wformat=]
>               left_len, sizeof(*phyerr));
>                         ^
> Fixes: 991adf71a6cd ("ath10k: refactor phyerr event handlers")
> Fixes: 2b0a2e0d7c2f ("ath10k: handle 10.4 firmware phyerr event")
>
> Signed-off-by: Raja Mani <rmani@qti.qualcomm.com>

Thanks, applied.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

      reply	other threads:[~2015-08-26  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-21 13:12 [PATCH] ath10k: Fix compilation warnings in wmi phyerr pull function Raja Mani
2015-08-26  9:34 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fv361jh9.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rmani@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox