From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOGe1-0003et-L1 for ath10k@lists.infradead.org; Tue, 14 Apr 2020 08:10:12 +0000 From: Kalle Valo Subject: Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio References: <20200212080415.31265-1-wgong@codeaurora.org> <20200212080415.31265-4-wgong@codeaurora.org> <87tv1su2vq.fsf@kamboji.qca.qualcomm.com> <185d31c2e6f8792beb240f2c74d26463@codeaurora.org> Date: Tue, 14 Apr 2020 11:10:00 +0300 In-Reply-To: <185d31c2e6f8792beb240f2c74d26463@codeaurora.org> (Wen Gong's message of "Thu, 09 Apr 2020 23:40:41 +0800") Message-ID: <87h7xmtrmv.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Wen Gong writes: > On 2020-04-09 22:53, Kalle Valo wrote: >> Wen Gong writes: >> >>> + ar->workqueue_tx_complete = >>> + create_singlethread_workqueue("ath10k_tx_complete_wq"); >>> + if (!ar->workqueue_tx_complete) >>> + goto err_free_aux_wq; >> >> We already have three threads: >> >> ath/ath10k/core.c: ar->workqueue = >> create_singlethread_workqueue("ath10k_wq"); >> ath/ath10k/core.c: ar->workqueue_aux = >> create_singlethread_workqueue("ath10k_aux_wq"); >> ath/ath10k/sdio.c: ar_sdio->workqueue = >> create_singlethread_workqueue("ath10k_sdio_wq"); >> >> Do we really need a fourth one? For example, why can't we use >> ar->workqueue_aux? > > For tcp test, it has 4 thread work meanwhile: > tx_bundle_skbs(ar->workqueue), > rx_indication(ar->workqueue_aux), > sdio_async_tx_request(ar_sdio->workqueue), > tx_bundle_complete(ar->workqueue_tx_complete) > > It has 4+ cpu/core in system, if reduced to 3 threads, then tcp > throughput will drop. only when it only has 1/2/3 cpu/core in system, > then reduced to 3 threads will not drop. How much does it drop? Please add the justification (with numbers) for the new thread to the commit log, so that the reason is properly documented. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k