ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Eduardo Abinader <eduardoabinader@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k:mac: disassoc dbg msg after return check
Date: Mon, 11 Nov 2019 11:22:50 +0200	[thread overview]
Message-ID: <87h83asr6d.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAGoNHni94JihdS-XovcC_zZ9YkMhSeoupfsMn2ioh9koA0EwmQ@mail.gmail.com> (Eduardo Abinader's message of "Mon, 11 Nov 2019 10:14:27 +0100")

Eduardo Abinader <eduardoabinader@gmail.com> writes:

> On Mon, 11 Nov 2019 at 09:50, Kalle Valo <kvalo@codeaurora.org> wrote:
>
>> Eduardo Abinader <eduardoabinader@gmail.com> writes:
>>
>> > Signed-off-by: Eduardo Abinader <eduardoabinader@gmail.com>
>>
>> No empty commit logs, please.
>>
>> > --- a/drivers/net/wireless/ath/ath10k/mac.c
>> > +++ b/drivers/net/wireless/ath/ath10k/mac.c
>> > @@ -6786,13 +6786,13 @@ static int ath10k_sta_state(struct ieee80211_hw
>> *hw,
>> >               /*
>> >                * Disassociation.
>> >                */
>> > -             ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM
>> disassociated\n",
>> > -                        sta->addr);
>> > -
>> >               ret = ath10k_station_disassoc(ar, vif, sta);
>> >               if (ret)
>> >                       ath10k_warn(ar, "failed to disassociate station:
>> %pM vdev %i: %i\n",
>> >                                   sta->addr, arvif->vdev_id, ret);
>> > +             else
>> > +                     ath10k_dbg(ar, ATH10K_DBG_MAC, "mac sta %pM
>> disassociated\n",
>> > +                        sta->addr);
>>
>> I don't understand, how is this better?
>>
>
> Either one msg or the other? I think a bit cleaner log.

I don't see it that way, the else branch makes the code harder to read
and for consistency it's better to always print the debug log.

> --000000000000b3b5a805970e8f8f
> Content-Type: text/html; charset="UTF-8"
> Content-Transfer-Encoding: quoted-printable

Please don't use HTML, I think the mailing lists drop all HTML mail
automatically.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

      parent reply	other threads:[~2019-11-11  9:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11  8:30 [PATCH] ath10k:mac: disassoc dbg msg after return check Eduardo Abinader
2019-11-11  8:50 ` Kalle Valo
     [not found]   ` <CAGoNHni94JihdS-XovcC_zZ9YkMhSeoupfsMn2ioh9koA0EwmQ@mail.gmail.com>
2019-11-11  9:22     ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h83asr6d.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=eduardoabinader@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox