From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Marek <mmarek@suse.com>
Cc: fengguang.wu@intel.com, linux-wireless@vger.kernel.org,
kbuild-all@01.org, ath10k@lists.infradead.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] ath10: Fix build with CONFIG_THERMAL=m
Date: Thu, 26 Nov 2015 19:01:42 +0200 [thread overview]
Message-ID: <87h9k8n18p.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1448552198-26911-1-git-send-email-mmarek@suse.com> (Michal Marek's message of "Thu, 26 Nov 2015 16:36:38 +0100")
+ linux-wireless
Michal Marek <mmarek@suse.com> writes:
> After commit cf4f21938e13 ("kbuild: Allow to specify composite modules
> with modname-m"), thermal.c gets included in the driver and the build
> fails with
>
> drivers/net/wireless/ath/ath10k/thermal.c:119:6: error: redefinition of ‘ath10k_thermal_event_temperature’
> drivers/net/wireless/ath/ath10k/thermal.h:54:20: note: previous definition of ‘ath10k_thermal_event_temperature’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:136:6: error: redefinition of ‘ath10k_thermal_set_throttling’
> drivers/net/wireless/ath/ath10k/thermal.h:59:20: note: previous definition of ‘ath10k_thermal_set_throttling’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:162:5: error: redefinition of ‘ath10k_thermal_register’
> drivers/net/wireless/ath/ath10k/thermal.h:45:19: note: previous definition of ‘ath10k_thermal_register’ was here
> drivers/net/wireless/ath/ath10k/thermal.c:216:6: error: redefinition of ‘ath10k_thermal_unregister’
> drivers/net/wireless/ath/ath10k/thermal.h:50:20: note: previous definition of ‘ath10k_thermal_unregister’ was here
>
> Change the #ifdef to reflect the new kbuild behavior.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Michal Marek <mmarek@suse.com>
Please fix the subject prefix to "ath10k: ", otherwise looks good. Feel
free to apply this to the kbuild tree.
Acked-by: Kalle Valo <kvalo@qca.qualcomm.com>
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-11-26 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201511260039.iQbaOe1h%fengguang.wu@intel.com>
2015-11-26 15:36 ` [PATCH] ath10: Fix build with CONFIG_THERMAL=m Michal Marek
2015-11-26 15:53 ` Michal Marek
2015-11-26 17:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9k8n18p.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox