From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Srinivasa Duvvuri <sduvvuri@chromium.org>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH v2] ath10k: handle cycle count wrap around
Date: Wed, 20 May 2015 15:42:27 +0300 [thread overview]
Message-ID: <87iobna098.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACZoB699sLr1gu1qSM1N01FQ5RNX41wDoOeCYd6A+sjyDRRU0A@mail.gmail.com> (Srinivasa Duvvuri's message of "Fri, 15 May 2015 15:29:49 -0700")
Srinivasa Duvvuri <sduvvuri@chromium.org> writes:
> This patch addresses
> couple of issues related to survey data that results in a random/large
> values in the out put of iw dev wlan0 surevey dump.
>
> These are the 2 changes that address the issue.
>
> 1) Handle Cycle count wrap around.
> When the cycle counts part of wmi_ch_info_ev_arg reach max value of
> 0xffffffff. The HW/FW right shifts all the counteirs by 1 . The cycle
> count will be reset to 0x7fffffff and starts counting from 0x7fffffff and
> the other counters will have their value right shifted by 1 (divided by 2).
> There is no way to handle this odd wrap around. Detect and ignore the wrap
> around case.
>
> 2) Handle Back to back channel info events from FW with
> WMI_CHAN_INFO_FLAG_COMPLETE.
> Between 2 scans FW sends back to back events with
> WMI_CHAN_INFO_FLAG_COMPLETE flag set. One at the end of first scan
> and the second at the beginning of scan. Depending on the time
> between 2 scans , the cycle counts could have wrapped around several
> timesi. Fix is detect and to ignore such events.
>
> Signed-off-by: Srinivasa Duvvuri <sduvvuri@chromium.org>
Please CC linux-wireless when sending ath10k patches.
Did you use git-send-email? There seems to be some kind of corruption:
patch -p1 < srini-1.mbox
patching file drivers/net/wireless/ath/ath10k/core.h
Hunk #1 FAILED at 688.
1 out of 1 hunk FAILED -- saving rejects to file drivers/net/wireless/ath/ath10k/core.h.rej
patching file drivers/net/wireless/ath/ath10k/wmi.c
patch: **** malformed patch at line 131: *ar, struct sk_buff *skb)
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-05-20 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 22:29 [PATCH v2] ath10k: handle cycle count wrap around Srinivasa Duvvuri
2015-05-18 12:05 ` Michal Kazior
2015-05-22 8:18 ` [PATCH v3 1/2] ath10k: handle cycle counter wraparound Michal Kazior
2015-05-22 8:18 ` [PATCH v3 2/2] ath10k: fix inconsistent survey reports Michal Kazior
2015-05-22 11:36 ` [PATCH v3 1/2] ath10k: handle cycle counter wraparound Kalle Valo
2015-05-22 11:56 ` Michal Kazior
2015-05-22 12:00 ` Michal Kazior
2015-05-22 12:12 ` Kalle Valo
[not found] ` <CACZoB6-+AUWN6gBqnwgJY101jfjBkDukLYNNffbe2bWNidjJ0Q@mail.gmail.com>
2015-05-25 8:23 ` Michal Kazior
2015-05-25 12:06 ` [PATCH v4 1/3] ath10k: move cycle_count macro Michal Kazior
2015-05-25 12:06 ` [PATCH v4 2/3] ath10k: handle cycle counter wraparound Michal Kazior
2015-05-25 12:06 ` [PATCH v4 3/3] ath10k: fix inconsistent survey reports Michal Kazior
2015-05-29 14:41 ` [PATCH v4 1/3] ath10k: move cycle_count macro Kalle Valo
2015-05-20 12:42 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iobna098.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=sduvvuri@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox