From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] ath10k: implement more versatile set_bitrate_mask
Date: Wed, 1 Apr 2015 20:09:23 +0300 [thread overview]
Message-ID: <87iodfzsfw.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmhEf3fZSo2FPFbXa=Uc4ia0Sg2SD89gceyc8O+jVJeUg@mail.gmail.com> (Michal Kazior's message of "Wed, 1 Apr 2015 14:38:13 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 31 March 2015 at 12:49, Michal Kazior <michal.kazior@tieto.com> wrote:
>> Until now only a single fixed tx rate or nss was
>> allowed to be set.
>>
>> The patch attempts to improve this by allowing
>> most bitrate masks. The limitation is VHT MCS
>> rates cannot be expressed separately and only the
>> following VHT MCS ranges are supported: none, 0-7,
>> 0-8, and 0-9.
>>
>> This keeps the old behaviour when requesting
>> single tx rate or single nss. The new bitrate mask
>> logic is only applied to other cases that would
>> return -EINVAL until now.
>>
>> Depending on firmware revisions some combinations
>> may crash firmware so use with care, please.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>> ---
>
> Hi Kalle,
>
> Drop this patch ([2/2]) for now, please. It looks like it doesn't work
> well with crypto networks. I'll need to rework this. The [1/2] is fine
> as it is though.
Ok, patch 2 dropped.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-04-01 17:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 10:49 [PATCH v2 0/2] ath10k: improve set_bitrate_mask Michal Kazior
2015-03-31 10:49 ` [PATCH v2 1/2] ath10k: clean up set_bitrate_mask handling Michal Kazior
2015-03-31 10:49 ` [PATCH v2 2/2] ath10k: implement more versatile set_bitrate_mask Michal Kazior
2015-04-01 12:38 ` Michal Kazior
2015-04-01 17:09 ` Kalle Valo [this message]
2015-04-01 17:34 ` [PATCH v2 0/2] ath10k: improve set_bitrate_mask Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iodfzsfw.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox