From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 3/3] ath10k: fix station count enforcement
Date: Tue, 25 Nov 2014 10:58:39 +0200 [thread overview]
Message-ID: <87ioi31wsg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmf6+U20083pHxMdDPMDZf=MNoup+CxBTn=azLZupQYPw@mail.gmail.com> (Michal Kazior's message of "Tue, 25 Nov 2014 09:38:41 +0100")
Michal Kazior <michal.kazior@tieto.com> writes:
>>> int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode)
>>> {
>>> int status;
>>> @@ -939,6 +950,8 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode)
>>> else
>>> ar->free_vdev_map = (1LL << TARGET_NUM_VDEVS) - 1;
>>>
>>> + ath10k_core_init_max_sta_count(ar);
>>
>> I don't see the need to call this during every firmware start as these
>> are not changed afterwards. I think it would be better to call this once
>> just after ath10k_core_fetch_firmware_files() is called.
>
> Hmm.. It makes sense but now that I think about it the max number of
> peers should actually depend on WMI_SERVICE_IRAM_TIDS which is known
> after booting firmware. However since only 10.x was released with the
> service enabled we used fw_features. So..
I think this is good enough for now. We can always improve this later.
> yeah. I can move the function call if you want though.
Please do that. To keep things simple I would like to have the absolute
minimum in start() calls.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-11-25 8:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 13:15 [PATCH 1/3] ath10k: add missing goto Michal Kazior
2014-11-24 13:15 ` [PATCH 2/3] ath10k: clean up num_peers locking Michal Kazior
2014-11-24 13:15 ` [PATCH 3/3] ath10k: fix station count enforcement Michal Kazior
2014-11-25 8:01 ` Kalle Valo
2014-11-25 8:38 ` Michal Kazior
2014-11-25 8:58 ` Kalle Valo [this message]
2014-11-25 14:16 ` [PATCH v2 1/3] ath10k: add missing goto Michal Kazior
2014-11-25 14:16 ` [PATCH v2 2/3] ath10k: clean up num_peers locking Michal Kazior
2014-11-25 14:16 ` [PATCH v2 3/3] ath10k: fix station count enforcement Michal Kazior
2014-11-26 6:44 ` [PATCH v2 1/3] ath10k: add missing goto Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioi31wsg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox