From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fs1Ms-0008Oe-MQ for ath10k@lists.infradead.org; Tue, 21 Aug 2018 07:46:24 +0000 From: Kalle Valo Subject: Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status() References: <1524291786-30850-1-git-send-email-akolli@codeaurora.org> <87zi1tav6h.fsf@kamboji.qca.qualcomm.com> <6b57525f3edc2b7d06b7662efc5d7e5f@codeaurora.org> <87y3hb8jtp.fsf@kamboji.qca.qualcomm.com> Date: Tue, 21 Aug 2018 10:46:07 +0300 In-Reply-To: (Anilkumar Kolli's message of "Tue, 21 Aug 2018 11:34:52 +0530") Message-ID: <87k1okqi0w.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Anilkumar Kolli Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Anilkumar Kolli writes: > On 2018-04-25 19:33, Kalle Valo wrote: >> Anilkumar Kolli writes: >> >>> On 2018-04-24 13:32, Kalle Valo wrote: >>>> Anilkumar Kolli writes: >>>> >>>>> Mesh path metric needs txrate information from ieee80211_tx_status() >>>>> call but in ath10k there is no mechanism to report tx rate >>>>> information >>>>> via ieee80211_tx_status(), the rate is only accessible via >>>>> sta_statiscs() op. >>>>> >>>>> Per peer stats has tx rate info available, this patch stores per >>>>> peer >>>>> last tx rate and updates the tx rate info structures in tx >>>>> completition. >>>>> The rate updated in ieee80211_tx_status() is not exactly for the >>>>> last >>>>> transmitted frame instead the rate is from one of the previous >>>>> frames. >>>>> >>>>> Per peer txrate information is updated through per peer statistics >>>>> and is available for QCA9888/QCA9984/QCA4019/QCA998X only >>>>> >>>>> Tested on QCA9984 with firmware-5.bin_10.4-3.5.3-00053 >>>>> Tested on QCA998X with firmware-5.bin_10.2.4-1.0-00036 >>>>> >>>>> Signed-off-by: Anilkumar Kolli >>>> >>>> BTW, your name in patchwork is "akolli@codeaurora.org" but it >>>> should be >>>> "Anilkumar Kolli" and that's why my script uses the wrong name. >>>> Please >>>> fix it by registering to patchwork as it's possible to change your >>>> name >>>> during registration, but only one time. If that doesn't work then >>>> send a >>>> request to helpdesk@kernel.org and the admins will fix it. >>> >>> I registered and updated name in the patchwork website. >> >> It seems that your name still is "akolli@codeaurora.org" in the >> Submitter field: >> >> https://patchwork.kernel.org/patch/10353959/ >> >> An example how it should look like: >> >> https://patchwork.kernel.org/patch/10359823/ >> >> I think you need to contact helpdesk now and ask them to fix it. >> >>> Do I need to resend the patch ? >> >> No need to resend because of this. > > Hi Kalle, > > Do you have any comments on this RFC. Shall I submit as a patch ? I have some questions about it but I haven't had a chance to look at in detail yet, hopefully later this week. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k