ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: ath10k@lists.infradead.org
Subject: Re: [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN
Date: Wed, 2 Oct 2013 07:59:36 +0300	[thread overview]
Message-ID: <87k3hw469z.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380679480.2081.24.camel@joe-AO722> (Joe Perches's message of "Tue, 01 Oct 2013 19:04:40 -0700")

(Cutting the CC smaller)

Joe Perches <joe@perches.com> writes:

> Convert the memset/memcpy uses of 6 to ETH_ALEN
> where appropriate.
>
> Also convert some struct definitions and u8 array
> declarations of [6] to ETH_ALEN.
>
> Signed-off-by: Joe Perches <joe@perches.com>

[...]

> diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
> index 55f90c7..bee88e8 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -1918,7 +1918,7 @@ int ath10k_wmi_peer_set_param(struct ath10k *ar, u32 vdev_id,
>  	cmd->vdev_id     = __cpu_to_le32(vdev_id);
>  	cmd->param_id    = __cpu_to_le32(param_id);
>  	cmd->param_value = __cpu_to_le32(param_value);
> -	memcpy(&cmd->peer_macaddr.addr, peer_addr, 6);
> +	memcpy(&cmd->peer_macaddr.addr, peer_addr, ETH_ALEN);
>  
>  	ath10k_dbg(ATH10K_DBG_WMI,
>  		   "wmi vdev %d peer 0x%pM set param %d value %d\n",

Acked-by: Kalle Valo <kvalo@qca.qualcomm.com>

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2013-10-02  5:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02  2:04 [PATCH net-next] net:drivers/net: Miscellaneous conversions to ETH_ALEN Joe Perches
2013-10-02  4:59 ` Kalle Valo [this message]
2013-10-02  6:40   ` Joe Perches
2013-10-02 17:44     ` Luis R. Rodriguez
2013-10-02 18:02       ` Joe Perches
2013-10-02 22:38         ` Julia Lawall
2013-10-03  0:09           ` Joe Perches
2013-10-03  0:28             ` Joe Perches
2013-10-03  3:31               ` Joe Perches
2013-10-03  3:39                 ` [PATCH net-next] ath10k: wmi: Convert use of 6 " Joe Perches
2013-10-03  3:44                   ` David Miller
2013-10-03  4:18                   ` Eric Dumazet
2013-10-03  4:34                     ` Kalle Valo
2013-10-03  4:44                       ` Eric Dumazet
2013-10-03  4:54                         ` Kalle Valo
2013-10-03  5:09                         ` Joe Perches
2013-10-03  5:24                           ` Eric Dumazet
2013-10-03  5:34                             ` Joe Perches
2013-10-03  5:47                               ` Julia Lawall
2013-10-03  6:00                               ` Eric Dumazet
2013-10-03  6:07                                 ` Joe Perches
2013-10-03  6:32                               ` Julia Lawall
2013-10-03  4:56                     ` Joe Perches
2013-10-03  5:43                     ` Julia Lawall
2013-10-03  5:41             ` [PATCH net-next] net:drivers/net: Miscellaneous conversions " Julia Lawall
2013-10-02  7:27 ` Arend van Spriel
2013-10-02 21:05 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k3hw469z.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=joe@perches.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox