From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Michal Kazior <michal.kazior@tieto.com>, ath10k@lists.infradead.org
Subject: Re: What to do about hung firmware?
Date: Wed, 6 Nov 2013 19:40:39 +0200 [thread overview]
Message-ID: <87li11e8dk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <527A739C.4060807@candelatech.com> (Ben Greear's message of "Wed, 6 Nov 2013 08:51:40 -0800")
Ben Greear <greearb@candelatech.com> writes:
> On 11/05/2013 11:46 PM, Kalle Valo wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> You probably could try WMI_ECHO_CMDID to implement a keep alive when
>>> idling (i.e. not sending WMI commands for a few seconds at least).
>>
>> Sending something periodically would be bad from power consumption point
>> of view. We would need to either disable it by default, only send it if
>> there's a problem or something like that.
>
> Ok, how about this:
>
> If we hit the 3*HZ timeout, then we send a ping to the firmware
> even if we are out of tickets.
>
> If we get no response to that in 3*HZ or so, then consider firmware
> hung and reset it.
Sounds good to me.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2013-11-06 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 18:51 What to do about hung firmware? Ben Greear
2013-11-06 7:07 ` Michal Kazior
2013-11-06 7:21 ` Ben Greear
2013-11-06 7:46 ` Kalle Valo
2013-11-06 16:51 ` Ben Greear
2013-11-06 17:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li11e8dk.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox