From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v3] ath10k: Bypass PLL setting on target init for QCA9888
Date: Wed, 27 May 2015 16:57:49 +0300 [thread overview]
Message-ID: <87mw0qyvfm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1430994663-30006-1-git-send-email-rmanohar@qti.qualcomm.com> (Rajkumar Manoharan's message of "Thu, 7 May 2015 16:01:03 +0530")
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes:
> Some of of qca988x solutions are having global reset issue
> during target initialization. Bypassing PLL setting before
> downloading firmware and letting the SoC run on REF_CLK is fixing
> the problem. Corresponding firmware change is also needed to set
> the clock source once the target is initialized. Since 10.2.4
> firmware is having this ROM patch, applying skip_clock_init only
> for 10.2.4 firmware versions.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
> index bcccae1..cb34619 100644
> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -1084,6 +1084,16 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode)
> if (status)
> goto err;
>
> + if ((ar->hw_rev == ATH10K_HW_QCA988X) &&
> + (ar->wmi.op_version == ATH10K_FW_WMI_OP_VERSION_10_2_4)) {
> + status = ath10k_bmi_write32(ar, hi_skip_clock_init, 1);
> + if (status) {
> + ath10k_err(ar, "could not write skip_clock_init (%d)\n",
> + status);
> + goto err;
> + }
> + }
I think it's better to use enum ath10k_fw_features for this as that
gives more flexibility how to enable this.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-05-27 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 10:31 [PATCH v3] ath10k: Bypass PLL setting on target init for QCA9888 Rajkumar Manoharan
2015-05-27 13:57 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw0qyvfm.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox