From: Kalle Valo <kvalo@kernel.org>
To: Francesco Magliocca <franciman12@gmail.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
ath10k@lists.infradead.org,
Dan Carpenter <dan.carpenter@oracle.com>,
rmanohar@qti.qualcomm.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: fix pointer arithmetic error in trace call
Date: Thu, 24 Feb 2022 09:34:31 +0200 [thread overview]
Message-ID: <87o82wvhtk.fsf@kernel.org> (raw)
In-Reply-To: <CAH4F6utmtAM3CzX2_Fbn94Sb-X8m0patPh8yWwbuBB0t1VYH=g@mail.gmail.com> (Francesco Magliocca's message of "Wed, 23 Feb 2022 12:48:36 +0100")
Francesco Magliocca <franciman12@gmail.com> writes:
> Hi, I picked (void*) to be conformant with the other examples in htt_rx.c
> For example at line 1431:
>> rxd = HTT_RX_BUF_TO_RX_DESC(hw,
>> (void *)msdu->data - hw->rx_desc_ops->rx_desc_size);
>
> But for me it is ok. Maybe we should fix all the occurrences of this kind.
Yeah, it would be good to fix the void pointer arithmetic in a separate
patch. I have planning to enable -Wpointer-arith in my ath10k-check and
ath11k-check scripts, so patches are very welcome.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2022-02-24 7:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 12:26 [PATCH v2] ath10k: fix pointer arithmetic error in trace call Francesco Magliocca
2022-02-22 20:52 ` Jeff Johnson
2022-02-23 11:48 ` Francesco Magliocca
2022-02-24 7:34 ` Kalle Valo [this message]
2022-02-24 7:53 ` Dan Carpenter
2022-02-24 9:59 ` Use of void pointer arithmetic? Kalle Valo
2022-02-24 10:31 ` Johannes Berg
2022-02-24 17:45 ` Linus Torvalds
2022-02-24 9:05 ` [PATCH v2] ath10k: fix pointer arithmetic error in trace call Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o82wvhtk.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=franciman12@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox