ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH 01/13] ath10k: introduce dynamic WMI structures
Date: Thu, 26 Sep 2013 11:54:52 +0300	[thread overview]
Message-ID: <87ob7grmhv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380101891-18312-2-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Wed, 25 Sep 2013 11:37:59 +0200")

Bartosz Markowski <bartosz.markowski@tieto.com> writes:

> This is the initial framework to implement dynamic
> WMI API in order to support new firmware (from so
> called 10.X branch)
>
> The realization is to have a static WMI cmd map for
> each of the firmwares, registered upom wmi init.
>
> This patch creates such map for MAIN FW, updates
> wmi_cmd_send() calls to take as a parameter
> the map value instead of direct WMI enum.
>
> As soon as complete 10.X API will be on place,
> we will introduce the FW IE mechanics to dynamicaly
> identify which FW is being used and based on that
> we will use correct map, API, structures, etc.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
> ---

[...]

> @@ -1293,7 +1438,8 @@ int ath10k_wmi_pdev_resume_target(struct ath10k *ar)
>  	if (skb == NULL)
>  		return -ENOMEM;
>  
> -	return ath10k_wmi_cmd_send(ar, skb, WMI_PDEV_RESUME_CMDID);
> +	return ath10k_wmi_cmd_send(ar, skb,
> +				   ar->wmi.cmd->wmi_pdev_resume_cmdid);
>  }

I was thinking of adding a macro WMI_PDEV_RESUME_CMDID(ar) for all
dynamic wmi ids, that way it would look as closely as possible with the
original code. But I'm not sure if that makes sense anymore. Thoughts?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2013-09-26  8:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25  9:37 [PATCH 00/13] ath10k: dual-firmware support (MAIN and 10.X) Bartosz Markowski
2013-09-25  9:37 ` [PATCH 01/13] ath10k: introduce dynamic WMI structures Bartosz Markowski
2013-09-25 10:38   ` Michal Kazior
2013-09-26  8:12   ` Kalle Valo
2013-09-26  8:54   ` Kalle Valo [this message]
2013-09-26  9:03     ` Michal Kazior
2013-09-26  9:07       ` Kalle Valo
2013-09-25  9:38 ` [PATCH 02/13] ath10k: add wmi_10x_<cmd/event> definitions Bartosz Markowski
2013-09-25  9:38 ` [PATCH 03/13] ath10k: warn if give WMI command is not supported Bartosz Markowski
2013-09-25  9:38 ` [PATCH 04/13] ath10k: implement WMI events handling frame for both firmwares Bartosz Markowski
2013-09-25  9:38 ` [PATCH 05/13] ath10k: split ath10k_wmi_service_ready_event_rx Bartosz Markowski
2013-09-25  9:38 ` [PATCH 06/13] ath10k: drop the fw versioning sanity check Bartosz Markowski
2013-09-25  9:38 ` [PATCH 07/13] ath10k: implement host memory chunks Bartosz Markowski
2013-09-26  9:04   ` Kalle Valo
2013-09-25  9:38 ` [PATCH 08/13] ath10k: bring back the WMI path for mgmt frames Bartosz Markowski
2013-09-25 10:46   ` Michal Kazior
2013-09-25  9:38 ` [PATCH 09/13] ath10k: split wmi_cmd_init path Bartosz Markowski
2013-09-26  8:15   ` Kalle Valo
2013-09-25  9:38 ` [PATCH 10/13] ath10k: add TARGET values for 10.x firmware Bartosz Markowski
2013-09-25  9:38 ` [PATCH 11/13] ath10k: introduce dynamic vdev parameters Bartosz Markowski
2013-09-25 10:38   ` Michal Kazior
2013-09-25  9:38 ` [PATCH 12/13] ath10k: introduce dynamic pdev parameters Bartosz Markowski
2013-09-25 10:39   ` Michal Kazior
2013-09-25  9:38 ` [PATCH 13/13] ath10k: handle FW API differences for scan structures Bartosz Markowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ob7grmhv.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=bartosz.markowski@tieto.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox