Re: [PATCH] ath10k: implement per-VDEV FW statistics

[Kalle Valo <kvalo@qca.qualcomm.com>]

Bartosz Markowski <bartosz.markowski@tieto.com> writes:

> The WMI_REQUEST_PEER_STAT command with latst (1.0.0.716) FW
> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>
> This is a backward compatible change. In case of older FW the VDEV
> statistics are simply not returned.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>

[...]

> diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
> index 08860c4..626bf02 100644
> --- a/drivers/net/wireless/ath/ath10k/wmi.h
> +++ b/drivers/net/wireless/ath/ath10k/wmi.h
> @@ -1767,6 +1772,9 @@ struct wal_dbg_tx_stats {
>  	/* wal pdev resets  */
>  	__le32 pdev_resets;
>  
> +	/* frames dropped due to non-availability of stateless TIDs */
> +	__le32 stateless_tid_alloc_failure;
> +
>  	__le32 phy_underrun;
>  
>  	/* MPDU is more than txop limit */
> @@ -1825,11 +1833,10 @@ enum wmi_stats_id {
>  
>  struct wmi_request_stats_cmd {
>  	__le32 stats_id;
> -
> -	/*
> -	 * Space to add parameters like
> -	 * peer mac addr
> -	 */
> +	/* unique id identifying the VDEV, generated by the caller */
> +	__le32 vdev_id;
> +	/* peer MAC address */
> +	struct wmi_mac_addr peer_macaddr;
>  } __packed;
>  
>  /* Suspend option */

Don't these changes break the compability with the older firmware?

Also, for consistency, please _v1 and _v2 suffix when having different
versions of wmi structs.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k