From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Erik Stromdahl <erik.stromdahl@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC v2 11/11] ath10k: Added sdio support
Date: Tue, 13 Dec 2016 13:10:53 +0000 [thread overview]
Message-ID: <87pokwynxf.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1479496971-19174-12-git-send-email-erik.stromdahl@gmail.com> (Erik Stromdahl's message of "Fri, 18 Nov 2016 20:22:51 +0100")
Erik Stromdahl <erik.stromdahl@gmail.com> writes:
> Initial HIF sdio/mailbox implementation.
>
> Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
While testing this I noticed few new warnings:
drivers/net/wireless/ath/ath10k/sdio.c: In function ath10k_sdio_probe:
drivers/net/wireless/ath/ath10k/sdio.c:1723:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
drivers/net/wireless/ath/ath10k/sdio.c:375:5: warning: symbol 'ath10k_sdio_mbox_rxmsg_pending_handler' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/sdio.c:1018:5: warning: symbol 'ath10k_sdio_hif_tx_sg' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/sdio.c:1415:5: warning: symbol 'ath10k_sdio_hif_exchange_bmi_msg' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/sdio.c:1555:5: warning: symbol 'ath10k_sdio_hif_map_service_to_pipe' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/sdio.c:1635:6: warning: symbol 'ath10k_sdio_hif_get_default_pipe' was not declared. Should it be static?
drivers/net/wireless/ath/ath10k/htc.c:265: line over 90 characters
drivers/net/wireless/ath/ath10k/htc.c:355: line over 90 characters
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-12-13 13:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 19:22 [RFC v2 00/11] ath10k sdio support Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 01/11] ath10k: htc: made static function public Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 02/11] ath10k: htc: rx trailer lookahead support Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 03/11] ath10k: htc: Removal of unused struct members Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 04/11] ath10k: htc: Changed order of wait target and ep connect Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 05/11] ath10k: htc: refactorization Erik Stromdahl
2016-12-13 13:44 ` Valo, Kalle
2016-12-13 13:52 ` Michal Kazior
2016-12-13 17:26 ` Valo, Kalle
2016-12-13 18:37 ` Erik Stromdahl
2016-12-13 19:21 ` Michal Kazior
2016-12-14 13:49 ` Valo, Kalle
2016-12-14 13:46 ` Valo, Kalle
2016-12-14 21:07 ` Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 06/11] ath10k: htc: Added ATH10K_HTC_FLAG_BUNDLE_LSB Erik Stromdahl
2016-12-16 10:23 ` Valo, Kalle
2016-11-18 19:22 ` [RFC v2 07/11] ath10k: Added SDIO dbg masks Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 08/11] ath10k: Added ATH10K_BUS_SDIO enum Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 09/11] ath10k: Mailbox address definitions Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 10/11] ath10k: Added more host_interest members Erik Stromdahl
2016-11-18 19:22 ` [RFC v2 11/11] ath10k: Added sdio support Erik Stromdahl
2016-12-13 13:10 ` Valo, Kalle [this message]
2016-12-15 16:40 ` Valo, Kalle
2016-12-15 20:52 ` Erik Stromdahl
2016-12-16 11:21 ` Valo, Kalle
2016-12-20 18:14 ` Erik Stromdahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pokwynxf.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=erik.stromdahl@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).