From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Liu CF/TW <cfliu.tw@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH V2] ath10k: add 'cryptmode' param to support raw tx injection and sw crypto.
Date: Mon, 8 Jun 2015 17:59:40 +0300 [thread overview]
Message-ID: <87pp56gs9v.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1433440033-49570-1-git-send-email-cfliu.tw@gmail.com> (Liu CF's message of "Thu, 4 Jun 2015 10:47:13 -0700")
Liu CF/TW <cfliu.tw@gmail.com> writes:
> This change supports bypassing HW crypto engine by enabling raw Rx/Tx mode.
> This will enable use cases such as sw crypto and raw tx injection.
> This change introduces a new module param 'cryptmode'.
Please use full words, eg. sw -> software, hw -> hardware
> cryptmode:
>
> 0 Use HW crypto engine. Use native WiFi mode Tx/Rx encap
"Use hardware crypto engine with native Wi-Fi mode TX/RX encapsulation
to the firmware"
> 1 Use SW crypto engine. Use raw mode Tx/Rx encap
"Use sofware crypto engine from mac80211 with raw mode TX/RX
encapsulation to the firmware"
> 2 Supports both SW & HW crypto engine. Use raw mode Tx/Rx encap.
It's not clear how to use this. How does the user choose between SW or
HW crypto modes? Please document that fully in the commit log.
> ath10k
> cryptmode
> param Testing Status
> ------- ---------------------------------
> 0 HW CCMP/TKIP tested ok.
> Note: HW crypto bypass not supported by ath10k hw in native WiFi
> mode.
What's "HW crypto bypass"? Please write the commit log so that everyone
can understand it.
> 1 - mac80211 SW crypto tested ok.
> - raw Tx frame injection tested ok.
What does "mac80211 SW crypto tested ok" exactly mean?
> 2 HW CCMP/TKIP tested ok.
> SW CCMP/TKIP tested ok.
How were the HW and SW modes chosen?
> Tested raw Tx encrypted frame injection ok.
With HW or SW crypto mode?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-06-08 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 17:47 [PATCH V2] ath10k: add 'cryptmode' param to support raw tx injection and sw crypto Liu CF/TW
2015-06-05 11:52 ` Michal Kazior
2015-06-08 14:49 ` Kalle Valo
2015-06-08 14:59 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp56gs9v.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=cfliu.tw@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox