From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XH73K-0000Sa-Bk for ath10k@lists.infradead.org; Tue, 12 Aug 2014 08:03:30 +0000 From: Kalle Valo Subject: Re: [PATCH 6/6] ath10k: move fw init print References: <1407402212-29809-1-git-send-email-michal.kazior@tieto.com> <1407402212-29809-7-git-send-email-michal.kazior@tieto.com> Date: Tue, 12 Aug 2014 10:53:04 +0300 In-Reply-To: <1407402212-29809-7-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 7 Aug 2014 11:03:32 +0200") Message-ID: <87ppg6qh3z.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Michal Kazior Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Michal Kazior writes: > Firmware probing is done only once when driver is > registered and firmware version is guaranteed to > remain the same until driver is unregistered. > > Signed-off-by: Michal Kazior [...] > @@ -816,24 +816,6 @@ int ath10k_core_start(struct ath10k *ar) > > INIT_LIST_HEAD(&ar->arvifs); > > - if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) { > - ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n", > - ar->hw_params.name, > - ar->target_version, > - ar->chip_id, > - ar->hw->wiphy->fw_version, > - ar->fw_api, > - ar->htt.target_version_major, > - ar->htt.target_version_minor); > - ath10k_info("debug %d debugfs %d tracing %d dfs %d\n", > - config_enabled(CONFIG_ATH10K_DEBUG), > - config_enabled(CONFIG_ATH10K_DEBUGFS), > - config_enabled(CONFIG_ATH10K_TRACING), > - config_enabled(CONFIG_ATH10K_DFS_CERTIFIED)); > - } > - > - __set_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags); Doesn't this break this print in pci.c: if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) ath10k_info("pci irq %s irq_mode %d reset_mode %d\n", irq_mode, ath10k_pci_irq_mode, ath10k_pci_reset_mode); -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k