From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68C9BC433EF for ; Mon, 4 Apr 2022 07:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0aFGz+lQXru7y2qkAN1LkcFGFpyJuBB9y8T4Btp81ZY=; b=KD1OwdYkYcqEpz QNshAApClF92VV15lg9BzvOEohy7kChIW92E815UjwvcDD17hovtK1jlIHh7R6ae2NzZSKEquDI3T Qw6G+0U0J2pZe/HvNHgYORb3UMOA8ktpAJqnAqm+oyrEzHcpxwVQyblyeQmzoQiGKvzAcoLhEDXAU yAfaqscRJhdWXPcJEURwV4J/UYh6B4FLfxTUVJi06YOQIUXecp5KSRmavEZ2XvSZp7aQhTGW9OE7y zWelhh3PMZVdFEf22cLQReWUd4uysnZ86l/lMSS2Hdecw5B6PpKukej2fj+Y6p8ihy71JS+I2wDYC vOoqu54PdGksUGBjAdtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbGxe-00Da0D-W4; Mon, 04 Apr 2022 07:17:15 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbGxb-00DZxa-AX for ath10k@lists.infradead.org; Mon, 04 Apr 2022 07:17:13 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01D62B80E77; Mon, 4 Apr 2022 07:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B71AC2BBE4; Mon, 4 Apr 2022 07:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649056628; bh=rSAJqJnEzLOmUA/q6lIY42NLKwgRv9JO6Lvbj00hQGU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LD+qLjSRC2bSBXSkPbDsg38XnxDSBf3zqiiKnNKSRx0Xcx1OEYNvhGDry6gwWCg6k sao4GqLFXPpYiMpyeU9oZy2g5C4C13ZVtW/NEbjhGmTSgboPGuSy+IMICxF+zmfbzV pzFSa5sXeSApwpVLBTIKI4aFCV4fyZe9q7W2oUWfkvLXd/4jPH3h/7v9h48xHN+tnl VlQ+TtmWeiPGaafdZNHDETiQIn2Ru0mmee4ylXjHuz/oo9tf0mGX8qhjJ4Vs+BKAQT 07a1zVE3HXOU5ycsGFXvR2XICg2cCnRsxwyojwmV27h1FAsF3zCygjF3lw6hhkF3+H jI0fsxvRlyCuQ== From: Kalle Valo To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH] arm64: dts: qcom: sdm845-db845c: add wifi variant property References: <20220403105711.1173161-1-dmitry.baryshkov@linaro.org> Date: Mon, 04 Apr 2022 10:17:05 +0300 In-Reply-To: <20220403105711.1173161-1-dmitry.baryshkov@linaro.org> (Dmitry Baryshkov's message of "Sun, 3 Apr 2022 13:57:11 +0300") Message-ID: <87r16ds4ge.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_001711_587919_E668C42D X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org Dmitry Baryshkov writes: > Dragonboard845c doesn't have board-specific board-id programmed, it uses > generic 0xff. Thus add the property with the 'variant' of the > calibration data. > > Note: the driver will check for the calibration data for the following > IDs, so older board-2.bin files that were distributed as a part of > Linaro releases will continue to work. > > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214,variant=Thundercomm_DB845C' > - 'bus=snoc,qmi-board-id=ff,qmi-chip-id=30214' > - 'bus=snoc,qmi-board-id=ff' > > For the reference, the board is identified by the driver in the > following way: > > ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40030001 > ath10k_snoc 18800000.wifi: qmi fw_version 0x2009856b fw_build_timestamp 2018-07-19 12:28 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.2.0-01387-QCAHLSWMTPLZ-1 > > Fixes: 3f72e2d3e682 ("arm64: dts: qcom: Add Dragonboard 845c") > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 13f80a0b6faa..f49de3913dd5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -1047,6 +1047,7 @@ &wifi { > vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; > > qcom,snoc-host-cap-8bit-quirk; > + qcom,ath10k-calibration-variant = "Thundercomm_DB845C"; I don't think I have documented it anywhere, but to keep things simple I would prefer to have the variant all lower case. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k