Re: [PATCH v6 2/3] ath10k: change max RX bundle size from 8 to 32 for sdio

Wen Gong
2019-10-24T09:40:30Z

On 2019-10-24 17:25, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>> The max bundle size support by firmware is 32, change it from 8 to 32
>> will help performance. This results in significant performance
>> improvement on RX path.
>>
>> Tested with QCA6174 SDIO with firmware
>> WLAN.RMH.4.4.1-00017-QCARMSWPZ-1
>>
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>> ---
>> drivers/net/wireless/ath/ath10k/htc.h | 12 +++++++++---
>> drivers/net/wireless/ath/ath10k/sdio.c | 4 ++--
>> drivers/net/wireless/ath/ath10k/sdio.h | 4 ++--
>> 3 files changed, 13 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/htc.h
>> b/drivers/net/wireless/ath/ath10k/htc.h
>> index f55d3ca..7055156 100644
>> --- a/drivers/net/wireless/ath/ath10k/htc.h
>> +++ b/drivers/net/wireless/ath/ath10k/htc.h
>> @@ -39,7 +39,7 @@
>> * 4-byte aligned.
>> */
>>
>> -#define HTC_HOST_MAX_MSG_PER_RX_BUNDLE 8
>> +#define HTC_HOST_MAX_MSG_PER_RX_BUNDLE 32
>
> So how do I know that this change doesn't break any other hardware? I
> did a quick review and I think it's safe, but the commit log mentions
> nothing about this.
the real max rx bundle is decided in ath10k_htc_wait_target.
it is the min value of HTC_HOST_MAX_MSG_PER_RX_BUNDLE and the value
reported from firmware.
htc->max_msgs_per_htc_bundle =
min_t(u8, msg->ready_ext.max_msgs_per_htc_bundle,
HTC_HOST_MAX_MSG_PER_RX_BUNDLE);
>
> Please clarify and I can update the commit log.