Re: [PATCH v6 3/3] ath10k: add workqueue for RX path of sdio

Wen Gong
2019-11-01T07:42:50Z

On 2019-10-31 17:08, Kalle Valo wrote:
、> I just realised that this is RX path so we should use
ATH10K_SKB_RXCB()
> instead. I made the change below to this commit in pending branch:
>
I will test with the new patch together with other performance patches.
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=28da1fe7a3ffa5c55c52328c21165d9efdf2e94c
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h
> b/drivers/net/wireless/ath/ath10k/core.h
> index af68eb5d0776..c5407f5080b2 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -124,6 +124,7 @@ struct ath10k_skb_cb {
> struct ath10k_skb_rxcb {
> dma_addr_t paddr;
> struct hlist_node hlist;
> + u8 eid;
> };
>
> static inline struct ath10k_skb_cb *ATH10K_SKB_CB(struct sk_buff *skb)
> diff --git a/drivers/net/wireless/ath/ath10k/sdio.c
> b/drivers/net/wireless/ath/ath10k/sdio.c
> index c34637881219..c7d09b07a382 100644
> --- a/drivers/net/wireless/ath/ath10k/sdio.c
> +++ b/drivers/net/wireless/ath/ath10k/sdio.c
> @@ -419,7 +419,7 @@ static int
> ath10k_sdio_mbox_rx_process_packets(struct ath10k *ar,
> struct ath10k_htc *htc = &ar->htc;
> struct ath10k_sdio_rx_data *pkt;
> struct ath10k_htc_ep *ep;
> - struct ath10k_skb_cb *cb;
> + struct ath10k_skb_rxcb *cb;
> enum ath10k_htc_ep_id id;
> int ret, i, *n_lookahead_local;
> u32 *lookaheads_local;
> @@ -466,7 +466,7 @@ static int
> ath10k_sdio_mbox_rx_process_packets(struct ath10k *ar,
> goto out;
>
> if (!pkt->trailer_only) {
> - cb = ATH10K_SKB_CB(pkt->skb);
> + cb = ATH10K_SKB_RXCB(pkt->skb);
> cb->eid = id;
>
> skb_queue_tail(&ar_sdio->rx_head, pkt->skb);
> @@ -1333,14 +1333,14 @@ static void
> ath10k_rx_indication_async_work(struct work_struct *work)
> async_work_rx);
> struct ath10k *ar = ar_sdio->ar;
> struct ath10k_htc_ep *ep;
> - struct ath10k_skb_cb *cb;
> + struct ath10k_skb_rxcb *cb;
> struct sk_buff *skb;
>
> while (true) {
> skb = skb_dequeue(&ar_sdio->rx_head);
> if (!skb)
> break;
> - cb = ATH10K_SKB_CB(skb);
> + cb = ATH10K_SKB_RXCB(skb);
> ep = &ar->htc.endpoint[cb->eid];
> ep->ep_ops.ep_rx_complete(ar, skb);
> }