Re: [PATCH v6 2/3] ath10k: change max RX bundle size from 8 to 32 for sdio

Wen Gong
2019-10-24T09:47:09Z

On 2019-10-24 17:30, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>> The max bundle size support by firmware is 32, change it from 8 to 32
>> will help performance. This results in significant performance
>> improvement on RX path.
>>
>> Tested with QCA6174 SDIO with firmware
>> WLAN.RMH.4.4.1-00017-QCARMSWPZ-1
>>
>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath10k/sdio.c
>> +++ b/drivers/net/wireless/ath/ath10k/sdio.c
>> @@ -24,7 +24,7 @@
>> #include "trace.h"
>> #include "sdio.h"
>>
>> -#define ATH10K_SDIO_VSG_BUF_SIZE (32 * 1024)
>> +#define ATH10K_SDIO_VSG_BUF_SIZE (64 * 1024)
>
> Is allocating 64 kb with kmalloc() reliable, especially on smaller
> systems? I hope it is, but checking if someone else knows better. We
> only do this only once in probe(), though.
rx packet is more than 1500 bytes for performance test, so for 32
packets, 32*1024 is not enough.
yes, it is allocated only one time for probe.