From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Sven Eckelmann <sven.eckelmann@openmesh.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Christian Lamparter <chunkeey@gmail.com>
Subject: Re: ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs
Date: Mon, 29 Jan 2018 11:10:58 +0000 [thread overview]
Message-ID: <87r2q8539d.fsf@qca.qualcomm.com> (raw)
In-Reply-To: <1728597.VOqZ93QOv6@bentobox> (Sven Eckelmann's message of "Mon, 29 Jan 2018 08:59:04 +0100")
Sven Eckelmann <sven.eckelmann@openmesh.com> writes:
> On Freitag, 26. Januar 2018 16:07:10 CET Kalle Valo wrote:
> [...]
>> > * bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42
>> > - sha256sum:
>> > 10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf
>> > * bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42
>> > - sha256sum:
>> > b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998
>>
>> I added these now:
>>
>> https://github.com/kvalo/ath10k-firmware/commit/5cd2bacd8e22217335e539b416d0cb8d59f8e312
>>
>> To make this easier I did some bigger changes in ath10k-bdencoder,
>> please check carefully that I didn't break anything.
>
> Tested it by extracting the files using the ath10k-bdencoder d278f25bc977
> (from 2017-02-10) and then calculating the sha256sum's using
>
> $ sha256sum bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin
> 10700a7ac636d57fe055e5bb4bd5f7bb3f1c282a7f25a8bb2204fc36e8c317bf bus=ahb,bmi-chip-id=0,bmi-board-id=16,variant=OM-A42.bin
> b3d9556894e509ac608b2e27c9169da12c63634670bb69c5ef21fb31583e7998 bus=ahb,bmi-chip-id=0,bmi-board-id=17,variant=OM-A42.bin
>
> It was also checked that the board-2.json only had these names attached to the
> .bin files.
>
> I did the same with my reference files and came to the same results. I am
> assuming that the files must have been added correctly when the names are
> correct and the content is correct.
>
> I have then extracted the version prior to the OM-A42 change and compared it
> to the one with OM-A42. The only difference I could find are related to the
> OM-A42. I must therefore also assume that only the relevant parts were changed
> and the other BDFs were not touched.
Good, thanks for checking!
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2018-01-29 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:45 ath10k-firmware: QCA4019 hw1.0: Add OpenMesh A42 specific BDFs Sven Eckelmann
2017-12-08 10:10 ` Sven Eckelmann
2018-01-26 16:07 ` Kalle Valo
2018-01-29 7:59 ` Sven Eckelmann
2018-01-29 11:10 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2q8539d.fsf@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=chunkeey@gmail.com \
--cc=sven.eckelmann@openmesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox