ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: enable qca6174 hw3.2
Date: Thu, 29 Jan 2015 14:44:49 +0200	[thread overview]
Message-ID: <87r3ud21tq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1422534273-18427-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 29 Jan 2015 13:24:33 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> The 3.2 revision has a different target BMI
> version so it wasn't recognized by ath10k (despite
> the chip_id rev being on the supported list
> already).
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

But uses the same binaries as hw3.0?

> +	{
> +		.id = QCA6174_HW_3_2_VERSION,
> +		.name = "qca6174 hw3.2",
> +		.patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR,
> +		.uart_pin = 6,
> +		.fw = {
> +			.dir = QCA6174_HW_3_0_FW_DIR,
> +			.fw = QCA6174_HW_3_0_FW_FILE,
> +			.otp = QCA6174_HW_3_0_OTP_FILE,
> +			.board = QCA6174_HW_3_0_BOARD_DATA_FILE,
> +			.board_size = QCA6174_BOARD_DATA_SZ,
> +			.board_ext_size = QCA6174_BOARD_EXT_DATA_SZ,
> +		},
> +	},
>  };

I added this in pending branch to avoid people wondering why it uses 3.0
binaries:

diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 36a8fcf349fa..310e12bc078a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -91,6 +91,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
                .patch_load_addr = QCA6174_HW_3_0_PATCH_LOAD_ADDR,
                .uart_pin = 6,
                .fw = {
+                       /* uses same binaries as hw3.0 */
                        .dir = QCA6174_HW_3_0_FW_DIR,
                        .fw = QCA6174_HW_3_0_FW_FILE,
                        .otp = QCA6174_HW_3_0_OTP_FILE,


-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2015-01-29 12:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 12:24 [PATCH] ath10k: enable qca6174 hw3.2 Michal Kazior
2015-01-29 12:44 ` Kalle Valo [this message]
2015-01-29 12:59   ` Michal Kazior
2015-02-04  7:23 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3ud21tq.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox