From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: implement drv_get_tsf for ibss merging
Date: Thu, 13 Feb 2014 21:13:35 +0200 [thread overview]
Message-ID: <87r4767rmo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1392197844-1223-1-git-send-email-yeohchunyeow@gmail.com> (Chun-Yeow Yeoh's message of "Wed, 12 Feb 2014 17:37:24 +0800")
Chun-Yeow Yeoh <yeohchunyeow@gmail.com> writes:
> Implement the get TSF by simply returning 0 so that IBSS
> merging is happening. Otherwise, IBSS nodes that have similar
> SSID naming won't merge. This is simply fooling the mac80211
> that the TSF in the received beacon is higher than the local TSF.
>
> Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com>
Yeah, this extremely ugly but don't really know any better way to handle
this now.
> +static u64 ath10k_get_tsf(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
> +{
> + struct ath10k *ar = hw->priv;
> + u64 tsf;
> +
> + mutex_lock(&ar->conf_mutex);
> + /* FIXME: Return 0 for time being. Need to figure out whether FW has
> + * the API to fetch 64-bit TSF
> + */
> + tsf = 0;
> + mutex_unlock(&ar->conf_mutex);
> +
> + return tsf;
> +}
But why do you need to take conf_mutex? Isn't this enough:
+static u64 ath10k_get_tsf(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
+{
+ /*
+ * FIXME: Return 0 for time being. Need to figure out whether FW
+ * has the API to fetch 64-bit TSF
+ */
+
+ return 0;
+}
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-02-13 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 9:37 [PATCH] ath10k: implement drv_get_tsf for ibss merging Chun-Yeow Yeoh
2014-02-13 19:13 ` Kalle Valo [this message]
2014-02-14 1:55 ` Yeoh Chun-Yeow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4767rmo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yeohchunyeow@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox