From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: ath10k@lists.infradead.org
Subject: Re: Fwd: ath10k related kernel crash in wireless-testing (3.12.0-rc3-wl+)
Date: Thu, 17 Oct 2013 11:43:13 +0300 [thread overview]
Message-ID: <87r4bk2spq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87li1t5gmi.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 16 Oct 2013 19:23:49 +0300")
Kalle Valo <kvalo@qca.qualcomm.com> writes:
> Ben Greear <greearb@candelatech.com> writes:
>
>> I sent this to the wrong list the first time.
>>
>> Do you know if this is already addressed? If not, I'll see if I can
>> find a fix.
>
> [...]
>
>> ath10k: MSI-X interrupt handling (8 intrs)
>> ath10k: Unable to wakeup target
>> ath10k: target took longer 5000 us to wake up (awake count 1)
>> ath10k: Failed to get pcie state addr: -16
>> ath10k: early firmware event indicated
>> BUG: unable to handle kernel NULL pointer dereference at 0000000000000004
>> IP: [<ffffffffa06ae46c>] ath10k_ce_completed_send_next+0x47/0x122
>> [ath10k_pci]
>
> I think there are two bugs here:
>
> 1) Cold reset doesn't always work, Michal has a patch for that. That's
> why the wakeup fails:
>
> http://lists.infradead.org/pipermail/ath10k/2013-October/000638.html
>
> 2) We enable interrupts too early and if wakeup fails and we get a
> spurious interrupt ath10k crashes. We don't have a fix for this yet.
I tried to look how to enable interrupts only after everything is
properly initialised in ath10k, but didn't find any quick way to do
that. I guess one ugly way to workaround this race is to add a state
variable which is checked in the interrupt handler.
Does anyone else have any other ideas?
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2013-10-17 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52588F0C.3000009@candelatech.com>
2013-10-16 16:00 ` Fwd: ath10k related kernel crash in wireless-testing (3.12.0-rc3-wl+) Ben Greear
2013-10-16 16:23 ` Kalle Valo
2013-10-17 8:43 ` Kalle Valo [this message]
2013-10-17 22:58 ` Michal Kazior
2013-10-18 6:29 ` Kalle Valo
2013-10-18 15:41 ` Michal Kazior
2013-10-21 14:00 ` Kalle Valo
2013-10-21 15:59 ` Ben Greear
2013-10-21 16:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4bk2spq.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox