From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iBe5w-0004U2-Gh for ath10k@lists.infradead.org; Sat, 21 Sep 2019 12:02:33 +0000 From: Kalle Valo Subject: Re: [PATCH v5 5/8] ath10k: disable TX complete indication of htt for sdio References: <1567679893-14029-1-git-send-email-wgong@codeaurora.org> <1567679893-14029-6-git-send-email-wgong@codeaurora.org> Date: Sat, 21 Sep 2019 15:02:28 +0300 In-Reply-To: <1567679893-14029-6-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Thu, 5 Sep 2019 18:38:10 +0800") Message-ID: <87v9tlamcr.fsf@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Wen Gong writes: > Tx complete message from firmware cost bus bandwidth of sdio, and bus > bandwidth is the bollteneck of throughput, it will effect the bandwidth > occupancy of data packet of TX and RX. TBH I'm not enthuastic about this, this feels an ugly hack. And it adds yet another module parameter which I detest. > This patch disable TX complete indication from firmware for htt data > packet, it results in significant performance improvement on TX path. So how much does this feature improve through exactly? Do you have any numbers? > The downside of this patch is ath10k will not know the TX status of > the data packet for poor signal situation. Although upper network stack > or application layer have retry mechanism, the retry will be later than > ath10k get the TX fail status if not disable TX complete. I don't understand this description. What's the difference in practise from user's point of view? But I think this patch should dropped from the patchset and revisited after rest of the patches are applied. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k