From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqG6Z-0000pE-9l for ath10k@lists.infradead.org; Wed, 24 Jul 2019 12:10:48 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: add mic bytes for pmf management packet References: <1560757079-19266-1-git-send-email-wgong@codeaurora.org> <136d04d4-671b-8dde-2abd-63070b07bd26@candelatech.com> <9403fef58374427fa76fb32ee64ee333@aptaiexm02f.ap.qualcomm.com> Date: Wed, 24 Jul 2019 15:10:42 +0300 In-Reply-To: <9403fef58374427fa76fb32ee64ee333@aptaiexm02f.ap.qualcomm.com> (Wen Gong's message of "Tue, 18 Jun 2019 07:21:30 +0000") Message-ID: <87v9vrzl8d.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: Ben Greear , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" , Wen Gong Wen Gong writes: >> -----Original Message----- >> From: ath10k On Behalf Of Ben >> Greear >> Sent: Tuesday, June 18, 2019 12:04 AM >> To: Wen Gong ; ath10k@lists.infradead.org >> Cc: linux-wireless@vger.kernel.org >> Subject: [EXT] Re: [PATCH] ath10k: add mic bytes for pmf management >> packet >> >> I was looking at mac80211 code recently, and it seems some action >> frames are NOT supposed to be protected. I added my own helper >> method to my local ath10k. Maybe you want to use this? >> >> >> /* Copied from ieee80211_is_robust_mgmt_frame, but disable the check for >> has_protected >> * since we do tx hw crypt, and it won't actually be encrypted even when this >> flag is >> * set. >> */ >> bool ieee80211_is_robust_mgmt_frame_tx(struct ieee80211_hdr *hdr) >> { >> if (ieee80211_is_disassoc(hdr->frame_control) || >> ieee80211_is_deauth(hdr->frame_control)) >> return true; >> >> if (ieee80211_is_action(hdr->frame_control)) { >> u8 *category; >> >> /* >> * Action frames, excluding Public Action frames, are Robust >> * Management Frames. However, if we are looking at a Protected >> * frame, skip the check since the data may be encrypted and >> * the frame has already been found to be a Robust Management >> * Frame (by the other end). >> */ >> /* >> if (ieee80211_has_protected(hdr->frame_control)) >> return true; >> */ >> category = ((u8 *) hdr) + 24; >> return *category != WLAN_CATEGORY_PUBLIC && >> *category != WLAN_CATEGORY_HT && >> *category != WLAN_CATEGORY_WNM_UNPROTECTED && >> *category != WLAN_CATEGORY_SELF_PROTECTED && >> *category != WLAN_CATEGORY_UNPROT_DMG && >> *category != WLAN_CATEGORY_VHT && >> *category != WLAN_CATEGORY_VENDOR_SPECIFIC; >> } >> >> return false; >> } >> >> Thanks, >> Ben >> >> > + >> > data_len = msdu->len; >> > >> > switch (txmode) { >> > >> >> > Thanks Ben, > > seems the ieee80211_is_robust_mgmt_frame_tx is not > match my change. So what's the conclusion, can I take this patch? -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k