From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Ben Greear <greearb@candelatech.com>,
ath10k <ath10k@lists.infradead.org>
Subject: Re: Hard lockup during vif restart tests.
Date: Thu, 18 Sep 2014 10:31:55 +0300 [thread overview]
Message-ID: <87vbols7tg.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQkcP=Yc8kA2=OotrWbaAf09aMOmiPQp5W2j1vxsu3x4Kg@mail.gmail.com> (Michal Kazior's message of "Thu, 18 Sep 2014 08:23:17 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
>> Why do we reset the firmware/NIC when we admin down/up the
>> vif (when a single vif is active)? Couldn't we just keep
>> the firmware active in this state and not risk lockup due
>> to reset?
>
> If you put down last interface mac80211 calls drv_stop(). There isn't
> any real need to keep the device up and running after that other than
> trying to workaround the reset issue. But then you need to deal with
> firmware quirks. I recall it could report Rx indications after all
> vdevs had been removed (and this is now also observable with 10.2
> during probing/bootup). It's just simpler to reboot firmware on
> drv_stop/start().
And there's the reliability issue. Being able to reset the firmware with
interface down/up sequency is pretty useful and AFAIK almost all
upstream drivers do that. And let's not forget power consumption either.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-09-18 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 18:42 Hard lockup during vif restart tests Ben Greear
2014-09-17 6:34 ` Michal Kazior
2014-09-17 15:52 ` Ben Greear
2014-09-18 6:23 ` Michal Kazior
2014-09-18 7:31 ` Kalle Valo [this message]
2014-09-18 16:06 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbols7tg.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox