ATH10K Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v2 7/7] ath10k: implement wmi-tlv backend
Date: Mon, 1 Dec 2014 16:19:23 +0200	[thread overview]
Message-ID: <87wq6bpi50.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQn=g8-=FEEoW7Ux+p6s=EBy_3rwCP3qXWk_8ijR6jXY+Q@mail.gmail.com> (Michal Kazior's message of "Fri, 28 Nov 2014 15:39:01 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 27 November 2014 at 10:11, Michal Kazior <michal.kazior@tieto.com> wrote:
>> Latest main firmware branch introduced a new WMI
>> ABI called wmi-tlv. It is not a tlv strictly
>> speaking but something that resembles it because
>> it is ordered and may have duplicate id entries.
>>
>> This prepares ath10k to support new hw.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> [...]
>> @@ -215,6 +254,42 @@ static inline char *wmi_service_name(int service_id)
>>         SVCSTR(WMI_SERVICE_BURST);
>>         SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT);
>>         SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT);
>> +       SVCSTR(WMI_SERVICE_ROAM_SCAN_OFFLOAD);
>> +       SVCSTR(WMI_SERVICE_AP_PS_DETECT_OUT_OF_SYNC);
>> +       SVCSTR(WMI_SERVICE_EARLY_RX);
> [...]
>> +       SVCSTR(WMI_SERVICE_RX_FULL_REORDER);
>> +       SVCSTR(WMI_SERVICE_DHCP_OFFLOAD);
>
> I've added 3 new service enums in v2:
> WMI_SERVICE_STA_RX_IPA_OFFLOAD_SUPPORT, WMI_SERVICE_MDNS_OFFLOAD,
> WMI_SERVICE_SAP_AUTH_OFFLOAD but apparently I forgot to add SVCSTR()
> for that..

I added those in my not-yet-submitted v3:

diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index a31a3028a847..7d091a74d3f3 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -290,6 +290,9 @@ static inline char *wmi_service_name(int service_id)
        SVCSTR(WMI_SERVICE_ROAM_HO_OFFLOAD);
        SVCSTR(WMI_SERVICE_RX_FULL_REORDER);
        SVCSTR(WMI_SERVICE_DHCP_OFFLOAD);
+       SVCSTR(WMI_SERVICE_STA_RX_IPA_OFFLOAD_SUPPORT);
+       SVCSTR(WMI_SERVICE_MDNS_OFFLOAD);
+       SVCSTR(WMI_SERVICE_SAP_AUTH_OFFLOAD);
        default:
                return NULL;
        }


-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  reply	other threads:[~2014-12-01 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27  9:11 [PATCH v2 0/7] ath10k: add support for new wmi-tlv backend Michal Kazior
2014-11-27  9:11 ` [PATCH v2 1/7] ath10k: fix wmi svc bitmap dbg print Michal Kazior
2014-11-27  9:11 ` [PATCH v2 2/7] ath10k: add sanity checks for service bmap parsing Michal Kazior
2014-11-27  9:11 ` [PATCH v2 3/7] ath10k: make wmi service bitmap non-debug Michal Kazior
2014-11-27  9:11 ` [PATCH v2 4/7] ath10k: implement intermediate event args Michal Kazior
2014-11-27  9:11 ` [PATCH v2 5/7] ath10k: introduce wmi ops Michal Kazior
2014-11-27  9:11 ` [PATCH v2 6/7] ath10k: make some wmi functions public Michal Kazior
2014-11-27  9:11 ` [PATCH v2 7/7] ath10k: implement wmi-tlv backend Michal Kazior
2014-11-28 14:39   ` Michal Kazior
2014-12-01 14:19     ` Kalle Valo [this message]
2014-11-27 12:59 ` [PATCH v2 0/7] ath10k: add support for new " Kalle Valo
2014-12-01  7:10 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wq6bpi50.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox