From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Simon Wunderlich <sw@simonwunderlich.de>,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
"Giori, Kathy" <kgiori@qca.qualcomm.com>,
Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature
Date: Thu, 24 Jul 2014 12:45:21 +0300 [thread overview]
Message-ID: <87wqb3qedq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQkmEoJ4TTDvBE9cagUGRFPKWVBFjGcyXfMsHHD9-bdDJA@mail.gmail.com> (Michal Kazior's message of "Thu, 24 Jul 2014 11:34:12 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 24 July 2014 11:29, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Simon Wunderlich <sw@simonwunderlich.de> writes:
>>
>>> Adds the spectral scan feature for ath10k. The spectral scan is triggered by
>>> configuring a mode through a debugfs control file. Samples can be gathered via
>>> another relay debugfs file.
>>>
> [...]
>>> @@ -800,8 +800,6 @@ int ath10k_core_start(struct ath10k *ar)
>>> else
>>> ar->free_vdev_map = (1 << TARGET_NUM_VDEVS) - 1;
>>>
>>> - INIT_LIST_HEAD(&ar->arvifs);
>>> -
>>> if (!test_bit(ATH10K_FLAG_FIRST_BOOT_DONE, &ar->dev_flags)) {
>>> ath10k_info("%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d\n",
>>> ar->hw_params.name,
>>> @@ -1084,6 +1082,12 @@ struct ath10k *ath10k_core_create(void *hif_priv, struct device *dev,
>>> INIT_WORK(&ar->register_work, ath10k_core_register_work);
>>> INIT_WORK(&ar->restart_work, ath10k_core_restart);
>>>
>>> + INIT_LIST_HEAD(&ar->arvifs);
>>
>> I'm a bit suspicious about this, why is it needed?
>
> Good hunch. ar->arvifs must be re-initialized in core_start for
> recovery to work correctly.
Thanks for the confirmation. I think I found a way to rework the
spectral initialisation which also fixes this issue, I'll send a new
version later today. Need to run some tests first.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-07-24 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 15:53 [PATCHv3 0/2] ath10k spectral scan support Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 1/2] ath: Move spectral debugfs structs to shared header Simon Wunderlich
2014-07-23 15:53 ` [PATCHv3 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-23 17:14 ` [PATCHv3 0/2] ath10k spectral scan support Kalle Valo
2014-07-23 17:32 ` [PATCHv3-ath-resend 2/2] ath10k: add spectral scan feature Simon Wunderlich
2014-07-24 9:29 ` Kalle Valo
2014-07-24 9:34 ` Michal Kazior
2014-07-24 9:45 ` Kalle Valo [this message]
2014-07-24 9:36 ` Simon Wunderlich
2014-07-24 9:40 ` Michal Kazior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqb3qedq.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=kgiori@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=michal.kazior@tieto.com \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox