From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD13CD5AE7C for ; Thu, 7 Nov 2024 09:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MWRI5EJVkFvUGx6C7YJn+xRBNNFAvzP+Auq975y6ebY=; b=GlxE5oS5gWbVBYzLEcztfX6Zcp QTOvbnaVnb3Y7A+8pF1bcxbQ3Rq4srVUPOJKOXKTTDQgv1T7JIMUr/cBsYcO0ELqpf35ODzNUf8/z SPfuj8AqTDQjVyo2bUmysLneMsVunV7Xb7mWk7oQHZzHlE9UMp7l/QLXMuNU429UXKRA54VOkoc26 71WaU2wqP0W2goYWVZL6sLWH92x9tW0I4ul5tkgU4N5Nu5EmOMpZtgxxAi+4uGmm06sBaIpr2jB5c LfBAnIyfrosd0RTj8vZSdEXsK9mIcDe37FIDxR2320LBDh2vxUtNuiq4EVrcUsw4uW2+Y3KkzeD03 ZSWBUtRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t8yzq-00000006KKU-0iUu; Thu, 07 Nov 2024 09:40:10 +0000 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t8yy3-00000006K80-41cM for ath10k@lists.infradead.org; Thu, 07 Nov 2024 09:38:23 +0000 Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-e333af0f528so701381276.3 for ; Thu, 07 Nov 2024 01:38:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1730972298; x=1731577098; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=MWRI5EJVkFvUGx6C7YJn+xRBNNFAvzP+Auq975y6ebY=; b=Re8mEs9clINlk+lLebXDNN7FAwt8cAb7Ja3XFkA36FrnxaODaNYE5hp4FL6M+oIC4z SVfpdGgz5fz9JxsSLf8gNVuOjxUAhpyoUn1s/8idV4eVa+jS6t5+QfR06ErOsXT1MjBg Zx0n0BsGymOOoCqT8t2EXtCz5VKYpR8kwG6hI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730972298; x=1731577098; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MWRI5EJVkFvUGx6C7YJn+xRBNNFAvzP+Auq975y6ebY=; b=Du+JArrZjTNwRpXEyGYkfFOoDy/J+YaD3hmFnUUGSOjRH2FfCOT1iGTpcwQclhA+ZD +WNoohF0fRGkUGmb6mJWVkNmZ/2wutJfi+9xHfuXQ1N/tWCPeffrJr0Wk8k8Wki8pkzl xin2WumeW/njMBtCAbJu340RUozMzxhuRKQQo1g/TDTYVyXv1kRjrqEVd+H4D3u26Zpq EGlLzO41kPQlEjK7ipgpOR2LuHWF+LGyMky2rDHzNcO6fefRu93VT/aN648H96OWXC8e aacqs4/DocffaI4b9AcCvEVf/KD8HwuydAwS2+6h8wPKjrq8GsBbxyD3aZ42nysKQFPe oX9g== X-Forwarded-Encrypted: i=1; AJvYcCXdo3sgI/dEw02ttKWdIkCWINmEnYiLY39SxRnuSnGYj8nDpiDRfZp/0rEriLDj/erIIXpVRyk=@lists.infradead.org X-Gm-Message-State: AOJu0Yxksoz52yt9pEtD09LDdwefyLg3KP5KH1NvoaaZ8PG5OPqTtINR c2c2Xeb1AR06P/MyWEOaiaJZGDv0l4GavbIKEzo+Zq6TkVuFeXSw8a8Pa3D8oA== X-Google-Smtp-Source: AGHT+IEg4zB9r4eKZAHG2EISGvc64OpTiaR4ghmMLpnW1RxREEGUdQgk1CXApcKl3AxBDAYGJUrviA== X-Received: by 2002:a05:690c:6a0b:b0:6ea:cc1b:e6e3 with SMTP id 00721157ae682-6ead60673a3mr4487367b3.33.1730972297955; Thu, 07 Nov 2024 01:38:17 -0800 (PST) Received: from [10.176.68.61] ([192.19.176.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d3966317f3sm5583696d6.118.2024.11.07.01.38.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 01:38:17 -0800 (PST) Message-ID: <8f8c6ac8-159a-425e-9d9b-b31c956f700d@broadcom.com> Date: Thu, 7 Nov 2024 10:38:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: Switch back to struct platform_driver::remove() To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Kalle Valo Cc: Jeff Johnson , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Loic Poulain , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Andy Shevchenko , Peter Chiu , Breno Leitao , "Russell King (Oracle)" , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, wcn36xx@lists.infradead.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20241106170706.38922-2-u.kleine-koenig@baylibre.com> Content-Language: en-US From: Arend van Spriel Autocrypt: addr=arend.vanspriel@broadcom.com; keydata= xsFNBGP96SABEACfErEjSRi7TA1ttHYaUM3GuirbgqrNvQ41UJs1ag1T0TeyINqG+s6aFuO8 evRHRnyAqTjMQoo4tkfy21XQX/OsBlgvMeNzfs6jnVwlCVrhqPkX5g5GaXJnO3c4AvXHyWik SOd8nOIwt9MNfGn99tkRAmmsLaMiVLzYfg+n3kNDsqgylcSahbd+gVMq+32q8QA+L1B9tAkM UccmSXuhilER70gFMJeM9ZQwD/WPOQ2jHpd0hDVoQsTbBxZZnr2GSjSNr7r5ilGV7a3uaRUU HLWPOuGUngSktUTpjwgGYZ87Edp+BpxO62h0aKMyjzWNTkt6UVnMPOwvb70hNA2v58Pt4kHh 8ApHky6IepI6SOCcMpUEHQuoKxTMw/pzmlb4A8PY//Xu/SJF8xpkpWPVcQxNTqkjbpazOUw3 12u4EK1lzwH7wjnhM3Fs5aNBgyg+STS1VWIwoXJ7Q2Z51odh0XecsjL8EkHbp9qHdRvZQmMu Ns8lBPBkzpS7y2Q6Sp7DcRvDfQQxPrE2sKxKLZVGcRYAD90r7NANryRA/i+785MSPUNSTWK3 MGZ3Xv3fY7phISvYAklVn/tYRh88Zthf6iDuq86m5mr+qOO8s1JnCz6uxd/SSWLVOWov9Gx3 uClOYpVsUSu3utTta3XVcKVMWG/M+dWkbdt2KES2cv4P5twxyQARAQABzS9BcmVuZCB2YW4g U3ByaWVsIDxhcmVuZC52YW5zcHJpZWxAYnJvYWRjb20uY29tPsLBhwQTAQgAMRYhBLX1Z69w T4l/vfdb0pZ6NOIYA/1RBQJj/ek9AhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQlno04hgD/VGw 8A//VEoGTamfCks+a12yFtT1d/GjDdf3i9agKMk3esn08JwjJ96x9OFFl2vFaQCSiefeXITR K4T/yT+n/IXntVWT3pOBfb343cAPjpaZvBMh8p32z3CuV1H0Y+753HX7gdWTEojGWaWmKkZh w3nGoRZQEeAcwcF3gMNwsM5Gemj7aInIhRLUeoKh/0yV85lNE1D7JkyNheQ+v91DWVj5/a9X 7kiL18fH1iC9kvP3lq5VE54okpGqUj5KE5pmHNFBp7HZO3EXFAd3Zxm9ol5ic9tggY0oET28 ucARi1wXLD/oCf1R9sAoWfSTnvOcJjG+kUwK7T+ZHTF8YZ4GAT3k5EwZ2Mk3+Rt62R81gzRF A6+zsewqdymbpwgyPDKcJ8YUHbqvspMQnPTmXNk+7p7fXReVPOYFtzzfBGSCByIkh1bB45jO +TM5ZbMmhsUbqA0dFT5JMHjJIaGmcw21ocgBcLsJ730fbLP/L08udgWHywPoq7Ja7lj5W0io ZDLz5uQ6CEER6wzD07vZwSl/NokljVexnOrwbR3wIhdr6B0Hc/0Bh7T8gpeM+QcK6EwJBG7A xCHLEacOuKo4jinf94YQrOEMnOmvucuQRm9CIwZrQ69Mg6rLn32pA4cK4XWQN1N3wQXnRUnb MTymLAoxE4MInhDVsZCtIDFxMVvBUgZiZZszN33OwU0EY/3pIgEQAN35Ii1Hn90ghm/qlvz/ L+wFi3PTQ90V6UKPv5Q5hq+1BtLA6aj2qmdFBO9lgO9AbzHo8Eizrgtxp41GkKTgHuYChijI kdhTVPm+Pv44N/3uHUeFhN3wQ3sTs1ZT/0HhwXt8JvjqbhvtNmoGosZvpUCTwiyM1VBF/ICT ltzFmXd5z7sEuDyZcz9Q1t1Bb2cmbhp3eIgLmVA4Lc9ZS3sK1UMgSDwaR4KYBhF0OKMC1OH8 M5jfcPHR8OLTLIM/Thw0YIUiYfj6lWwWkb82qa4IQvIEmz0LwvHkaLU1TCXbehO0pLWB9HnK r3nofx5oMfhu+cMa5C6g3fBB8Z43mDi2m/xM6p5c3q/EybOxBzhujeKN7smBTlkvAdwQfvuD jKr9lvrC2oKIjcsO+MxSGY4zRU0WKr4KD720PV2DCn54ZcOxOkOGR624d5bhDbjw1l2r+89V WLRLirBZn7VmWHSdfq5Xl9CyHT1uY6X9FRr3sWde9kA/C7Z2tqy0MevXAz+MtavOJb9XDUlI 7Bm0OPe5BTIuhtLvVZiW4ivT2LJOpkokLy2K852u32Z1QlOYjsbimf77avcrLBplvms0D7j6 OaKOq503UKfcSZo3lF70J5UtJfXy64noI4oyVNl1b+egkV2iSXifTGGzOjt50/efgm1bKNkX iCVOYt9sGTrVhiX1ABEBAAHCwXYEGAEIACAWIQS19WevcE+Jf733W9KWejTiGAP9UQUCY/3p PgIbDAAKCRCWejTiGAP9UaC/EACZvViKrMkFooyACGaukqIo/s94sGuqxj308NbZ4g5jgy/T +lYBzlurnFmIbJESFOEq0MBZorozDGk+/p8pfAh4S868i1HFeLivVIujkcL6unG1UYEnnJI9 uSwUbEqgA8vwdUPEGewYkPH6AaQoh1DdYGOleQqDq1Mo62xu+bKstYHpArzT2islvLdrBtjD MEzYThskDgDUk/aGPgtPlU9mB7IiBnQcqbS/V5f01ZicI1esy9ywnlWdZCHy36uTUfacshpz LsTCSKICXRotA0p6ZiCQloW7uRH28JFDBEbIOgAcuXGojqYx5vSM6o+03W9UjKkBGYFCqjIy Ku843p86Ky4JBs5dAXN7msLGLhAhtiVx8ymeoLGMoYoxqIoqVNaovvH9y1ZHGqS/IYXWf+jE H4MX7ucv4N8RcsoMGzXyi4UbBjxgljAhTYs+c5YOkbXfkRqXQeECOuQ4prsc6/zxGJf7MlPy NKowQLrlMBGXT4NnRNV0+yHmusXPOPIqQCKEtbWSx9s2slQxmXukPYvLnuRJqkPkvrTgjn5d eSE0Dkhni4292/Nn/TnZf5mxCNWH1p3dz/vrT6EIYk2GSJgCLoTkCcqaM6+5E4IwgYOq3UYu AAgeEbPV1QeTVAPrntrLb0t0U5vdwG7Xl40baV9OydTv7ghjYZU349w1d5mdxg== In-Reply-To: <20241106170706.38922-2-u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241107_013820_117307_1A64C042 X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On 11/6/2024 6:07 PM, Uwe Kleine-König wrote: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all platform drivers below drivers/net/wireless to use > .remove(), with the eventual goal to drop struct > platform_driver::remove_new(). As .remove() and .remove_new() have the > same prototypes, conversion is done by just changing the structure > member name in the driver initializer. > > En passant several whitespace changes are done to make indentation > consistent in the struct initializers. I am fine with the patch as is, but it is really up to Kalle. For brcmfmac here is my... Acked-by: Arend van Spriel