From: Simon Wunderlich <sw@simonwunderlich.de>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org
Subject: Re: Re: [PATCH] ath10k: unregister spectral before mac
Date: Thu, 14 Aug 2014 14:22:04 +0200 [thread overview]
Message-ID: <9205567.prhmu1LLGe@prime> (raw)
In-Reply-To: <87wqabmlc2.fsf@kamboji.qca.qualcomm.com>
On Thursday 14 August 2014 13:12:13 Kalle Valo wrote:
> Simon Wunderlich <sw@simonwunderlich.de> writes:
> > If spectral is unregistered after mac80211, the relayfs file has already
> > been removed recursively by mac/cfg80211, and spectral tries to remove
> > the file once more, thus leading to double free problems. Better clean
> > up spectral before to avoid that problem.
> >
> > Reported-by: Kalle Valo <kvalo@qca.qualcomm.com>
> > Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
>
> Thanks for checking this. But I'm just wondering why even bother to call
> relay_close() in the first place if mac80211 recursively removes
> everything anyway? We don't remove any of the debugfs files anyway.
We need to relay_close() in any case because this function also causes to
clean up internal buffers of relayfs.
An alternative to this patch could be to instead having
remove_buf_file_handler() call debugfs_remove() just do nothing and relay on
the upper layers to (recursively) remove that file - then, the relayfs stuff
still can get cleaned up. But that's also not very elegant either. If you
prefer that I can prepare a patch though ....
Cheers,
Simon
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2014-08-14 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 15:12 [PATCH] ath10k: unregister spectral before mac Simon Wunderlich
2014-08-14 10:12 ` Kalle Valo
2014-08-14 12:22 ` Simon Wunderlich [this message]
2014-08-14 12:41 ` Kalle Valo
2014-08-14 13:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9205567.prhmu1LLGe@prime \
--to=sw@simonwunderlich.de \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox