From: Manikanta Pubbisetty <mpubbise@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Sebastian Gottschall <s.gottschall@dd-wrt.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH] ath10k: add dynamic vlan support
Date: Wed, 23 May 2018 16:09:12 +0530 [thread overview]
Message-ID: <988f350d-a6eb-1733-4a2f-43a87053e96a@codeaurora.org> (raw)
In-Reply-To: <1527069018.3759.15.camel@sipsolutions.net>
>>>> + * @IEEE80211_HW_SUPPORTS_SW_ENCRYPT: Device is capable of transmitting
>>>> + * frames encrypted in software, only valid when SW_CRYPTO_CONTROL
>>>> + * is enabled. Based on this flag, mac80211 can allow/disallow VLAN
>>>> + * operations in the BSS.
>>> Based on the name and initial description, this sounds equivalent to
>>> just turning off SW_CRYPTO_CONTROL. I think that's not the intent, but
>>> would need some renaming.
>> I can rename it to something which is very specific to VLAN support on
>> sw crypto controlled devices if that is okay.
> I don't think that makes sense. If we split the capability of AP_VLAN
> and AP_VLAN_FOR_4ADDR at the "root", then we don't need to play with all
> these things. Yes, this is slightly awkward for userspace, and perhaps
> with the interface combination checks, but I'd like you to look at that.
>
Makes sense, I had this thought to split the VLAN and 4-addr
functionality, but since we need to fiddle with userspace, I refrained.
Anyways, I will check all the possibilities of splitting these
functionalities.
Thanks,
Manikanta
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2018-05-23 10:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 13:57 [PATCH] ath10k: add dynamic vlan support Manikanta Pubbisetty
2018-04-23 19:18 ` Sebastian Gottschall
2018-05-18 9:53 ` Johannes Berg
2018-05-18 10:40 ` Sebastian Gottschall
2018-04-24 8:09 ` Kalle Valo
2018-04-24 9:09 ` Sebastian Gottschall
2018-04-24 9:18 ` Manikanta Pubbisetty
2018-04-24 9:52 ` Kalle Valo
2018-04-24 9:55 ` Sebastian Gottschall
2018-05-04 6:50 ` Manikanta Pubbisetty
2018-05-05 9:50 ` Sebastian Gottschall
2018-05-18 9:54 ` Johannes Berg
2018-05-18 10:52 ` Sebastian Gottschall
2018-05-21 6:42 ` Manikanta Pubbisetty
2018-05-23 9:50 ` Johannes Berg
2018-05-23 10:39 ` Manikanta Pubbisetty [this message]
2018-05-23 10:39 ` Johannes Berg
2018-05-23 10:50 ` Manikanta Pubbisetty
2018-05-24 4:41 ` Sebastian Gottschall
2018-06-18 20:49 ` Johannes Berg
2018-08-14 12:53 ` Manikanta Pubbisetty
2018-08-16 8:27 ` Johannes Berg
2018-08-24 5:50 ` Manikanta Pubbisetty
2018-09-03 10:39 ` Johannes Berg
2018-09-05 6:03 ` Manikanta Pubbisetty
[not found] ` <15ca06c2-0d43-99c1-8f31-19e73629ab70@codeaurora.org>
2018-08-24 8:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=988f350d-a6eb-1733-4a2f-43a87053e96a@codeaurora.org \
--to=mpubbise@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.gottschall@dd-wrt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox