From: Erik Stromdahl <erik.stromdahl@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH 1/1] mac80211: ieee80211_rx_napi: remove warning
Date: Thu, 8 Jun 2017 19:10:08 +0200 [thread overview]
Message-ID: <9a570231-00c2-e234-8ac8-fbee66bd07af@gmail.com> (raw)
In-Reply-To: <1496872642.3291.4.camel@sipsolutions.net>
On 2017-06-07 23:57, Johannes Berg wrote:
> On Sun, 2017-06-04 at 15:11 +0200, Erik Stromdahl wrote:
>> The softirq count is not always incremented during driver
>> operation. This is the case for usb and sdio network
>> drivers.
>
> I'm pretty sure the warning is correct, and we do rely on having
> local_bh_disable(), otherwise we may end up taking a soft-IRQ and I
> believe there are some things that could get messed up in that case.
>
Ok, I will make sure to increment the softirq counter before calling
ieee80211_rx then.
> So - I think the warning is there for a reason, and drivers should just
> local_bh_disable() before calling into that. What's wrong with that?
I guess there is nothing wrong with that, it's just that ath10k does not
call local_bh_disable anywhere in the code.
I guess it is relying on lower layers (pcie?) to do that.
When introducing sdio and usb support these calls will have to be added
explicitly in ath10k.
>
> johannes
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2017-06-08 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 13:11 [PATCH 0/1] mac80211: removal of warning in RX path Erik Stromdahl
2017-06-04 13:11 ` [PATCH 1/1] mac80211: ieee80211_rx_napi: remove warning Erik Stromdahl
2017-06-07 21:57 ` Johannes Berg
2017-06-08 17:10 ` Erik Stromdahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a570231-00c2-e234-8ac8-fbee66bd07af@gmail.com \
--to=erik.stromdahl@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox