From: Ben Greear <greearb@candelatech.com>
To: linux-wireless@vger.kernel.org, kvalo@qca.qualcomm.com,
ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fix setting txpower to zero.
Date: Fri, 13 Dec 2019 13:55:17 -0800 [thread overview]
Message-ID: <a56bee1a-e3b9-2999-f643-d10ebe5d4726@candelatech.com> (raw)
In-Reply-To: <20191212171409.21041-1-greearb@candelatech.com>
On 12/12/19 9:14 AM, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> Do not ignore 0 txpower setting unless the vif is of type p2p.
My patch has problems I think: secondary stations also have un-init
txpower when they are first built and start scanning.
So, I'm going to try setting txpower to -1 in mac80211 and use that
to mean 'unset'.
Thanks,
Ben
>
> This should fix regression in:
>
> commit 88407beb1b1462f706a1950a355fd086e1c450b6
> Author: Ryan Hsu <ryanhsu@qca.qualcomm.com>
> Date: Tue Dec 13 14:55:19 2016 -0800
>
> ath10k: fix incorrect txpower set by P2P_DEVICE interface
>
> Tested (without p2p in use) on 9984 with ath10k-ct firmware, but I don't think
> this is firmware specific.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 289d03da14b2..1c5e1b5570f8 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -5902,11 +5902,18 @@ static int ath10k_mac_txpower_recalc(struct ath10k *ar)
> {
> struct ath10k_vif *arvif;
> int ret, txpower = -1;
> + int p2p_st;
> +
> + p2p_st = ath10k_wmi_get_vdev_subtype(ar, WMI_VDEV_SUBTYPE_P2P_DEVICE);
>
> lockdep_assert_held(&ar->conf_mutex);
>
> list_for_each_entry(arvif, &ar->arvifs, list) {
> - if (arvif->txpower <= 0)
> + /* p2p may not initialize txpower, and we should ignore it
> + * in that case.
> + */
> + if ((arvif->txpower < 0) ||
> + ((arvif->txpower == 0) && (arvif->vdev_subtype == p2p_st)))
> continue;
>
> if (txpower == -1)
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2019-12-13 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 17:14 [PATCH] ath10k: Fix setting txpower to zero greearb
2019-12-13 21:55 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a56bee1a-e3b9-2999-f643-d10ebe5d4726@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox