From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXn4S-0002x6-3k for ath10k@lists.infradead.org; Fri, 14 Dec 2018 13:00:01 +0000 MIME-Version: 1.0 Date: Fri, 14 Dec 2018 18:29:47 +0530 From: Rakesh Pillai Subject: Re: [PATCH v2] ath10k: skip sending quiet mode cmd for WCN3990 In-Reply-To: <87ftv0xqwp.fsf@kamboji.qca.qualcomm.com> References: <1544782666-24837-1-git-send-email-kvalo@codeaurora.org> <87ftv0xqwp.fsf@kamboji.qca.qualcomm.com> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Govind Singh , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Hi Kalle, I tested this patch on WCN3990 and did basic STA mode sanity. I do not see any crash with this fix. Thanks, Rakesh Pillai. On 2018-12-14 17:26, Kalle Valo wrote: > Kalle Valo writes: > >> From: Rakesh Pillai >> >> HL2.0 firmware does not support setting quiet mode. If the host >> driver sends >> the quiet mode setting command to the HL2.0 firmware, it crashes with >> the below >> signature. >> >> fatal error received: err_qdi.c:456:EX:wlan_process:1:WLAN >> RT:207a:PC=b001b4f0 >> >> The quiet mode command support is exposed by the firmware via thermal >> throttle >> wmi service. Enable ath10k thermal support if thermal throttle wmi >> service bit >> is set. 10.x firmware versions support this feature by default, but >> unfortunately do not advertise the support via service flags, hence >> have to >> manually set the service flag in ath10k_core_compat_services(). >> >> Compile tested only. > > I'm planning to queue this for 4.20 as wcn3990 support won't work > otherwise. But I wasn't able to test this so can someone help, please? _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k