From: Venkateswara Naralasetty <vnaralas@codeaurora.org>
To: Jasmine Strong <jas@eero.com>
Cc: linux-wireless-owner@vger.kernel.org,
Ben Greear <greearb@candelatech.com>,
linux-wireless@vger.kernel.org,
ath10k <ath10k@lists.infradead.org>
Subject: Re: [PATCHv2] ath10k : Fix channel survey dump
Date: Thu, 09 Aug 2018 12:05:23 +0530 [thread overview]
Message-ID: <d586156d3861a6cf0f479ff12ddd6544@codeaurora.org> (raw)
On 2018-08-01 00:03, Jasmine Strong wrote:
> On Tue, Jul 31, 2018 at 10:38 AM Ben Greear <greearb@candelatech.com>
> wrote:
>
>> On 07/31/2018 05:11 AM, Venkateswara Naralasetty wrote:
>>> Channel active/busy time are showing incorrect(less than previous
>> or
>>> sometimes zero) for successive survey dump command.
>>>
>>> example:
>>> Survey data from wlan0
>>> frequency: 5180 MHz [in use]
>>> channel active time: 54995 ms
>>> channel busy time: 432 ms
>>> channel receive time: 0 ms
>>> channel transmit time: 59 ms
>>> Survey data from wlan0
>>> frequency: 5180 MHz [in use]
>>> channel active time: 32592 ms
>>> channel busy time: 254 ms
>>> channel receive time: 0 ms
>>> channel transmit time: 0 ms
>>>
>>> This patch fix this issue by assigning 'wmi_bss_survey_req_type'
>>> as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in
>>> FW and send survey data to driver upon the driver request. Wrap
>> around
>>> is taken care by FW.
>>>
>>> hardware used : QCA9984
>>> firmware ver : ver 10.4-3.5.3-00057
>>
>> Have you tested this on other firmwares? I am pretty sure that at
>> least
>> some of them, probably 10.2, will have issues.
>>
>> Maybe you could make this change specific to certain firmware that
>> is known to work with the change?
>
> There are bigger problems with it than that; even with firmwares that
> behave correctly,
> this changes the behavior that a lot of upper-layer software depends
> upon, and will likely
> make anything that actually uses the channel survey data misbehave.
>
> It is therefore a breaking change for any device that actually
> implements ACS.
>
> -J.
In ath9k driver also survey data being accumulated in driver and send
survey data to user space is accumulated one. same thing we are
implementing in FW(with WMI request type WMI_BSS_SURVEY_REQ_TYPE_READ)
instead of doing it in driver.
Thanks,
Venkatesh.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2018-08-09 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 6:35 Venkateswara Naralasetty [this message]
2018-08-09 18:46 ` [PATCHv2] ath10k : Fix channel survey dump Peter Oh
2018-08-09 22:26 ` Sven Eckelmann
-- strict thread matches above, loose matches on Subject: below --
2018-07-31 12:11 Venkateswara Naralasetty
2018-07-31 17:37 ` Ben Greear
2018-08-01 8:47 ` Venkateswara Naralasetty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d586156d3861a6cf0f479ff12ddd6544@codeaurora.org \
--to=vnaralas@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=jas@eero.com \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox