Re: [PATCHv2 2/2] ath10k: Allow setting coverage class

[Sebastian Gottschall <s.gottschall@dd-wrt.com>]

Am 04.08.2016 um 07:28 schrieb Michal Kazior:
> On 3 August 2016 at 17:37, Sebastian Gottschall <s.gottschall@dd-wrt.com> wrote:
>>>> +       if (value < 0)
>>>> +               value = ar->fw_coverage.coverage_class;
>>>> +
>>>> +       /* Break out if the coverage class and registers have the
>>>> expected
>>>> +        * value.
>>>> +        */
>>>> +       if (value == ar->fw_coverage.coverage_class &&
>>>> +           slottime_reg == ar->fw_coverage.reg_slottime_conf &&
>>>> +           timeout_reg == ar->fw_coverage.reg_ack_cts_timeout_conf)
>>>> +               goto unlock;
>>> I would move this part to the caller and keep the hardware-specific
>>> function just compute and set registers, e.g. have
>>> ath10k_mac_set_coverage_class (as opposed to
>>> ath10k_mac_op_set_coverage_class). It should also reduce some code
>>> duplication.
>> doesnt make sense. i already enhanced this code to support beeliner (99xx)
>> and newers.
>> the code is that much different that this check need to be treaded in a
>> indivudual way
>> reg_slottime_conf is hardware defacto specific since the value is taken from
>> a hardware specific register.
>> you cannot handle this outside this function since other chips have
>> different registers.
> Ah, you're right, my bad :)
the current code i sended to benjamin makes several of these vars 
obsolete anyway.
just waiting for his new cleaned up version here on that list.

>
>
> Michał
>


-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Berliner Ring 101, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k