From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hskrp-0003MD-Iz for ath10k@lists.infradead.org; Wed, 31 Jul 2019 09:25:54 +0000 Message-ID: Subject: Re: [PATCHv6 1/9] nl80211: New netlink command for TID specific configuration From: Johannes Berg Date: Wed, 31 Jul 2019 11:25:51 +0200 In-Reply-To: <1560835632-17405-2-git-send-email-tamizhr@codeaurora.org> References: <1560835632-17405-1-git-send-email-tamizhr@codeaurora.org> <1560835632-17405-2-git-send-email-tamizhr@codeaurora.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Tamizh chelvam , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org On Tue, 2019-06-18 at 10:57 +0530, Tamizh chelvam wrote: > > /** > + * enum nl80211_tid_config - TID config state > + * @NL80211_TID_CONFIG_DEFAULT: Default config for the TID > + * @NL80211_TID_CONFIG_ENABLE: Enable config for the TID > + * NL80211_TID_CONFIG_DISABLE: Disable config for the TID > + */ > +enum nl80211_tid_config { > + NL80211_TID_CONFIG_DEFAULT, > + NL80211_TID_CONFIG_ENABLE, > + NL80211_TID_CONFIG_DISABLE, > +}; Hmm. Looking at this in more detail in patch 3, I don't understand. How is DEFAULT different from "attribute not present", i.e. "no changes"? johannes _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k