From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtps.newmedia-net.de ([185.84.6.167] helo=webmail.newmedia-net.de) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dJKee-0007Zv-HS for ath10k@lists.infradead.org; Fri, 09 Jun 2017 14:12:52 +0000 Subject: Re: [PATCH v2 1/3] ath10k: Use complete VHT chan width for 160MHz workaround References: <20170609110750.14950-1-sven.eckelmann@openmesh.com> From: Sebastian Gottschall Message-ID: Date: Fri, 9 Jun 2017 16:09:01 +0200 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="windows-1252"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Ben Greear , Sven Eckelmann , ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org Am 09.06.2017 um 15:50 schrieb Ben Greear: > > > On 06/09/2017 04:07 AM, Sven Eckelmann wrote: >> From: Ben Greear >> >> The ath10k firmware doesn't announce its VHT channel width = >> capabilities in >> the vht_cap information from the "service ready event" arguments. The >> driver must therefore check whether the 160MHz short GI bit is set and >> whether the driver still doesn't set the bits for the 160/80+80 MHz >> capabilities. >> >> The two bits for the channel width are a two bit integer and not two >> separate bits which cannot be parsed without the knowledge of the other >> bit. Using IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ (b10..) = >> as a >> mask for this task doesn't make any sense. The correct mask for the VHT >> channel width should be used instead to make this check more readable. > > I didn't test them, but a quick review looks good. Thanks for picking = > this up! mmh except that it wont change anything. this patch is a workaround for = older firmwares. these older firmwares have this flag zeroed newer firmwares have 80p80 set. thats all. for sure we can now check if = the mask is 0 or not 0. but it wont change anything at the end > > --Ben > > -- = Mit freundlichen Gr=FCssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Berliner Ring 101, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Gesch=E4ftsf=FChrer: Peter Steinh=E4user, Christian Scheele http://www.dd-wrt.com email: s.gottschall@dd-wrt.com Tel.: +496251-582650 / Fax: +496251-5826565 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k