From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMST4-0001To-Jq for ath10k@lists.infradead.org; Tue, 13 Nov 2018 06:46:35 +0000 MIME-Version: 1.0 Date: Tue, 13 Nov 2018 12:16:22 +0530 From: Tamizh chelvam Subject: Re: [PATCH 1/4] New netlink command for TID specific configuration In-Reply-To: References: <1540230918-27712-1-git-send-email-tamizhr@codeaurora.org> <1540230918-27712-2-git-send-email-tamizhr@codeaurora.org> <20181107140552.zfuusbapgqjumoln@bars> <0b75171a7777bd25e203240a3a119cb5@codeaurora.org> <20181109094017.j4vkhaprz4zmszch@bars> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Vasanthakumar Thiagarajan , Sergey Matyukevich , ath10k@lists.infradead.org On 2018-11-09 17:54, Johannes Berg wrote: > On Fri, 2018-11-09 at 09:40 +0000, Sergey Matyukevich wrote: >> >> Ok. So if driver receives retry value (-1), it should reset to some >> default value known to driver or firmware. IMHO it worth making it >> more explicit: in its current form this convention will not be obvious >> for driver authors. Though I don't have a good idea how to do it. >> Maybe merge both aggregation and retry cfg80211 callbacks into one >> and use structure for params and bitmask for operations... > > I think we want that anyway, I just suggested to also add the "noack" > to > the same API, and indeed it's pointless to set retries and noack. > Sure, I'll change it to a single api for all the tid_config operations. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k