Re: [PATCH] ath11k: Update tx descriptor search index properly

[Peter Oh <peter.oh@eero.com>]

On 1/26/21 6:46 PM, Karthikeyan periyasamy wrote:
> On 2020-12-19 00:53, Peter Oh wrote:
>> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>>> Tx descriptor search index field should be updated with hw peer id
>>> and not by AST Hash. Incorrect search index causes throughput 
>>> degradation
>>> in all the platforms. so updated the search index field with hw peer 
>>> id,
>>> which is a common change applicable for all the platforms.
>>>
>>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>>>
>>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>>> b/drivers/net/wireless/ath/ath11k/peer.c
>>> index b69e7eb..f49abefa 100644
>>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>>>
>>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, 
>>> struct ath11k_vif *arvif,
>>>         peer->pdev_idx = ar->pdev_idx;
>>>       peer->sta = sta;
>>> -    arvif->ast_hash = peer->ast_hash;
>>> +
>>> +    if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>>> +        arvif->ast_hash = peer->ast_hash;
>>> +        arvif->ast_idx = peer->hw_peer_id;
>>> +    }
>>
>> How about non STATION type?
>>
>
> no need of configuring the ast_idx, ast_hash field for non station 
> type. Its recommended by HW/FW team.
>
Can you add this comment in commit message?

Also could you include the answer to "what conditions you observed the
throughput degradation?" in commit message too?


Thanks,

Peter


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k