From: Venkateswara Naralasetty <vnaralas@codeaurora.org>
To: ath11k@lists.infradead.org
Cc: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Subject: [PATCH] ath11k: fix target assert when unload driver
Date: Wed, 8 May 2019 20:15:26 +0530 [thread overview]
Message-ID: <1557326726-29837-1-git-send-email-vnaralas@codeaurora.org> (raw)
Currently ath11k_ahb_ext_irq_disable() called before ath11k_mac_unregister
which will disable napi before mac_unregister and still we might receive
packets on all active devices which results reo_dest_ring full.
Fix this issue by moving ath11k_ahb_ext_irq_disable() after
ath11k_mac_unregister().
Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index dc56df5..e3e6b64 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -486,6 +486,7 @@ static int ath11k_core_pdev_create(struct ath11k_base *sc)
static void ath11k_core_pdev_destroy(struct ath11k_base *sc)
{
ath11k_mac_unregister(sc);
+ ath11k_ahb_ext_irq_disable(sc);
ath11k_dp_pdev_free(sc);
}
@@ -781,7 +782,6 @@ void ath11k_core_deinit(struct ath11k_base *sc)
{
mutex_lock(&sc->core_lock);
- ath11k_ahb_ext_irq_disable(sc);
ath11k_core_pdev_destroy(sc);
ath11k_core_stop(sc);
--
2.7.4
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next reply other threads:[~2019-05-08 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 14:45 Venkateswara Naralasetty [this message]
2019-05-13 14:50 ` [PATCH] ath11k: fix target assert when unload driver Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557326726-29837-1-git-send-email-vnaralas@codeaurora.org \
--to=vnaralas@codeaurora.org \
--cc=ath11k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox