From: Venkateswara Naralasetty <vnaralas@codeaurora.org>
To: ath11k@lists.infradead.org
Cc: Venkateswara Naralasetty <vnaralas@codeaurora.org>
Subject: [PATCH] ath11k: reject tx fragmentation configuration
Date: Wed, 8 May 2019 20:16:04 +0530 [thread overview]
Message-ID: <1557326764-29931-1-git-send-email-vnaralas@codeaurora.org> (raw)
Currently no known firmware actually implements frag threshold support.
Moreover it is not possible to rely frame fragmentation to mac80211
because firmware clears the "more fragments" bit in frame control making
it impossible for remote devices to reassemble frames.
Hence implement a dummy callback just to say fragmentation isn't
supported. This effectively prevents mac80211 from doing frame
fragmentation in software.
This fixes Tx becoming broken after setting fragmentation threshold.
Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
---
drivers/net/wireless/ath/ath11k/mac.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index dc2733c..aa805a4 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -4300,10 +4300,17 @@ static int ath11k_set_rts_threshold(struct ieee80211_hw *hw, u32 value)
static int ath11k_set_frag_threshold(struct ieee80211_hw *hw, u32 value)
{
- struct ath11k *ar = hw->priv;
- int param_id = WMI_VDEV_PARAM_FRAGMENTATION_THRESHOLD;
-
- return ath11k_set_vdev_param_to_all_vifs(ar, param_id, value);
+ /* Even though there's a WMI vdev param for fragmentation threshold no
+ * known firmware actually implements it. Moreover it is not possible to
+ * rely frame fragmentation to mac80211 because firmware clears the
+ * "more fragments" bit in frame control making it impossible for remote
+ * devices to reassemble frames.
+ *
+ * Hence implement a dummy callback just to say fragmentation isn't
+ * supported. This effectively prevents mac80211 from doing frame
+ * fragmentation in software.
+ */
+ return -EOPNOTSUPP;
}
static void ath11k_flush(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
--
2.7.4
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next reply other threads:[~2019-05-08 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 14:46 Venkateswara Naralasetty [this message]
2019-05-13 14:50 ` [PATCH] ath11k: reject tx fragmentation configuration Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557326764-29931-1-git-send-email-vnaralas@codeaurora.org \
--to=vnaralas@codeaurora.org \
--cc=ath11k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox