From: Kalle Valo <kvalo@kernel.org>
To: Anilkumar Kolli <akolli@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Anilkumar Kolli <akolli@codeaurora.org>
Subject: Re: [PATCH] ath11k: update debugfs support for mupltiple radios in PCI bus
Date: Thu, 22 Dec 2022 15:28:18 +0000 (UTC) [thread overview]
Message-ID: <167172289467.8231.1004330123245787946.kvalo@kernel.org> (raw)
In-Reply-To: <1614160542-27882-1-git-send-email-akolli@codeaurora.org>
Anilkumar Kolli <akolli@codeaurora.org> wrote:
> debugfs_ath11k struct is moved to ath11k_core, since its common
> for both pci and ahb.
>
> Current ath11k_pci insmod fails if there are multiple PCI rdaios,
>
> ath11k_pci 0000:01:00.0: Hardware name qcn9074 hw1.0
> debugfs: Directory 'ath11k' with parent '/' already present!
> ath11k_pci 0000:01:00.0: failed to create ath11k debugfs
> ath11k_pci 0000:01:00.0: failed to create soc core: -17
> ath11k_pci 0000:01:00.0: failed to init core: -17
> ath11k_pci: probe of 0000:01:00.0 failed with error -17
>
> To avoid the failure, debugfs directory is created with soc_name
> and bus_id to allow creating debugfs directory for second PCI radio.
>
> with this Debugfs entries looks like,
> # ls -l /sys/kernel/debug/ath11k/
> ipq8074 hw2.0 qcn9000 hw1.0_0000:01:00.0 qcn9000 hw1.0_0001:01:00.0
>
> # ls -l /sys/kernel/debug/ath11k/ipq8074 hw2.0/
> mac0 mac1 simulate_fw_crash soc_dp_stats
>
> # ls -l /sys/kernel/debug/ath11k/qcn9000 hw1.0_0000:01:00.0
> mac0 simulate_fw_crash soc_dp_stats
>
> # /sys/kernel/debug/ath11k/qcn9000 hw1.0_0001:01:00.0:
> mac0 simulate_fw_crash soc_dp_stats
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1.r2-00012-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
I submitted my version here:
https://patchwork.kernel.org/project/linux-wireless/patch/20221220121231.20120-1-kvalo@kernel.org/
--
https://patchwork.kernel.org/project/linux-wireless/patch/1614160542-27882-1-git-send-email-akolli@codeaurora.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2022-12-22 15:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 9:55 [PATCH] ath11k: update debugfs support for mupltiple radios in PCI bus Anilkumar Kolli
2022-12-22 15:28 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167172289467.8231.1004330123245787946.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox